Moving RedHat domain content for 3 new placement methods to ManageIQ.

[billfitzgerald0120]

Moving/Adding RedHat Automate methods for Infrastructure/Vm/Provisioning/Placement to the ManageIQ domain.

These are methods that are NOT currently in ManageIQ domain.

@miq-bot assign @tinaafitz

[miq-bot]

Checked commit billfitzgerald0120@2289e20 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 40 offenses detected

content/automate/ManageIQ/Infrastructure/VM/Provisioning/Placement.class/methods/redhat_best_placement_with_scope.rb

• ❗ - Line 10, Col 1 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 114, Col 61 - Style/SymbolProc - Pass &:name as an argument to collect instead of a block.
• ❗ - Line 12, Col 1 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 13, Col 4 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 13, Col 6 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• ❗ - Line 14, Col 1 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 161, Col 3 - Style/Next - Use next to skip iteration.
• ❗ - Line 16, Col 1 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 175, Col 41 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 175, Col 43 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• ❗ - Line 198, Col 1 - Layout/EmptyLinesAroundBlockBody - Extra empty line detected at block body end.
• ❗ - Line 199, Col 5 - Style/CommentedKeyword - Do not place comments on the same line as the end keyword.
• ❗ - Line 19, Col 5 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 19, Col 7 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• ❗ - Line 24, Col 61 - Layout/SpaceAfterComma - Space missing after comma.
• ❗ - Line 46, Col 19 - Style/MutableConstant - Freeze mutable objects assigned to constants.
• ❗ - Line 73, Col 27 - Style/SymbolProc - Pass &:pop as an argument to collect instead of a block.
• ❗ - Line 80, Col 22 - Style/MutableConstant - Freeze mutable objects assigned to constants.

content/automate/ManageIQ/Infrastructure/VM/Provisioning/Placement.class/methods/vmware_best_fit_with_scope.rb

• ❗ - Line 114, Col 61 - Style/SymbolProc - Pass &:name as an argument to collect instead of a block.
• ❗ - Line 11, Col 1 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 12, Col 4 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 12, Col 6 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• ❗ - Line 15, Col 7 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• ❗ - Line 164, Col 3 - Style/Next - Use next to skip iteration.
• ❗ - Line 178, Col 41 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 178, Col 43 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• ❗ - Line 19, Col 61 - Layout/SpaceAfterComma - Space missing after comma.
• ❗ - Line 201, Col 1 - Layout/EmptyLinesAroundBlockBody - Extra empty line detected at block body end.
• ❗ - Line 202, Col 5 - Style/CommentedKeyword - Do not place comments on the same line as the end keyword.
• ❗ - Line 42, Col 19 - Style/MutableConstant - Freeze mutable objects assigned to constants.
• ❗ - Line 73, Col 27 - Style/SymbolProc - Pass &:pop as an argument to collect instead of a block.
• ❗ - Line 80, Col 22 - Style/MutableConstant - Freeze mutable objects assigned to constants.
• ❗ - Line 9, Col 1 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.

content/automate/ManageIQ/Infrastructure/VM/Provisioning/Placement.class/methods/vmware_best_fit_with_tags.rb

• ❗ - Line 10, Col 1 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 83, Col 3 - Style/Next - Use next to skip iteration.
• ❗ - Line 84, Col 18 - Performance/CompareWithBlock - Use sort_by(&:free_space) instead of sort { |a, b| a.free_space <=> b.free_space }.
• ❗ - Line 84, Col 18 - Style/UnneededSort - Use max instead of sort...last.
• ❗ - Line 8, Col 1 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 9, Col 4 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 9, Col 6 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.

[coveralls]

Pull Request Test Coverage Report for Build 4043

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.02%) to 97.248%

---

Totals
Change from base Build 4030:	-0.02%
Covered Lines:	3004
Relevant Lines:	3089

---

💛 - Coveralls