Moving RedHat domain content for 8 existing methods to ManageIQ.

[billfitzgerald0120]

Moving/Replacing 8 RedHat Automate methods to the ManageIQ domain:
2 for Cloud/Vm/Provisioning/StateMachine/Methods
6 for Infrastructure/Vm/Provisioning/StateMachine/Methods

These are methods that are currently in the ManageIQ domain.

@miq-bot assign @tinaafitz

[miq-bot]

Some comments on commit billfitzgerald0120@24a0a8c

content/automate/ManageIQ/Infrastructure/VM/Provisioning/StateMachines/Methods.class/methods/redhat_customizerequest.rb

• 💣 💥 🔥 🚒 - 203 - Detected cfme
• 💣 💥 🔥 🚒 - 218 - Detected cfme

content/automate/ManageIQ/Infrastructure/VM/Provisioning/StateMachines/Methods.class/methods/vmware_customizerequest.rb

• 💣 💥 🔥 🚒 - 149 - Detected cfme
• 💣 💥 🔥 🚒 - 167 - Detected cfme

[miq-bot]

Some comments on commit billfitzgerald0120@24a0a8c

content/automate/ManageIQ/Infrastructure/VM/Provisioning/StateMachines/Methods.class/methods/redhat_customizerequest.rb

• 💣 💥 🔥 🚒 - 203 - Detected cfme
• 💣 💥 🔥 🚒 - 218 - Detected cfme

content/automate/ManageIQ/Infrastructure/VM/Provisioning/StateMachines/Methods.class/methods/vmware_customizerequest.rb

• 💣 💥 🔥 🚒 - 149 - Detected cfme
• 💣 💥 🔥 🚒 - 167 - Detected cfme

[miq-bot]

Checked commit billfitzgerald0120@24a0a8c with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
8 files checked, 109 offenses detected

content/automate/ManageIQ/Cloud/VM/Provisioning/StateMachines/Methods.class/methods/amazon_customizerequest.rb

• ⚠️ - Line 6, Col 52 - Lint/UnusedMethodArgument - Unused method argument - product. If it's necessary, use _ or _product as an argument name to indicate that it won't be used.
• ⚠️ - Line 9, Col 3 - Lint/EmptyWhen - Avoid when branches without a body.
• ❗ - Line 14, Col 58 - Style/PreferredHashMethods - Use Hash#key? instead of Hash#has_key?.
• ❗ - Line 23, Col 66 - Style/PreferredHashMethods - Use Hash#key? instead of Hash#has_key?.
• ❗ - Line 26, Col 62 - Layout/SpaceAfterComma - Space missing after comma.
• ❗ - Line 32, Col 62 - Style/PreferredHashMethods - Use Hash#key? instead of Hash#has_key?.
• ❗ - Line 42, Col 57 - Style/RescueModifier - Avoid using rescue in its modifier form.
• ❗ - Line 44, Col 57 - Style/RescueModifier - Avoid using rescue in its modifier form.
• ❗ - Line 52, Col 146 - Layout/SpaceAroundOperators - Surrounding space missing for operator ==.
• ❗ - Line 59, Col 151 - Layout/SpaceAroundOperators - Surrounding space missing for operator ==.
• ❗ - Line 66, Col 147 - Layout/SpaceAroundOperators - Surrounding space missing for operator ==.
• ❗ - Line 6, Col 69 - Layout/SpaceInsideParens - Space inside parentheses detected.
• ❗ - Line 73, Col 9 - Style/RescueModifier - Avoid using rescue in its modifier form.
• ❗ - Line 80, Col 7 - Style/CommentedKeyword - Do not place comments on the same line as the end keyword.
• ❗ - Line 84, Col 35 - Layout/SpaceAroundEqualsInParameterDefault - Surrounding space missing in default value assignment.
• ❗ - Line 85, Col 19 - Style/UnneededInterpolation - Prefer to_s over string interpolation.
• ❗ - Line 86, Col 40 - Style/UnneededInterpolation - Prefer to_s over string interpolation.
• ❗ - Line 96, Col 12 - Style/RescueModifier - Avoid using rescue in its modifier form.

content/automate/ManageIQ/Cloud/VM/Provisioning/StateMachines/Methods.class/methods/openstack_customizerequest.rb

• ⚠️ - Line 6, Col 52 - Lint/UnusedMethodArgument - Unused method argument - product. If it's necessary, use _ or _product as an argument name to indicate that it won't be used.
• ⚠️ - Line 9, Col 3 - Lint/EmptyWhen - Avoid when branches without a body.
• ❗ - Line 14, Col 58 - Style/PreferredHashMethods - Use Hash#key? instead of Hash#has_key?.
• ❗ - Line 23, Col 66 - Style/PreferredHashMethods - Use Hash#key? instead of Hash#has_key?.
• ❗ - Line 26, Col 62 - Layout/SpaceAfterComma - Space missing after comma.
• ❗ - Line 32, Col 62 - Style/PreferredHashMethods - Use Hash#key? instead of Hash#has_key?.
• ❗ - Line 42, Col 57 - Style/RescueModifier - Avoid using rescue in its modifier form.
• ❗ - Line 44, Col 57 - Style/RescueModifier - Avoid using rescue in its modifier form.
• ❗ - Line 52, Col 146 - Layout/SpaceAroundOperators - Surrounding space missing for operator ==.
• ❗ - Line 59, Col 151 - Layout/SpaceAroundOperators - Surrounding space missing for operator ==.
• ❗ - Line 66, Col 147 - Layout/SpaceAroundOperators - Surrounding space missing for operator ==.
• ❗ - Line 6, Col 69 - Layout/SpaceInsideParens - Space inside parentheses detected.
• ❗ - Line 73, Col 9 - Style/RescueModifier - Avoid using rescue in its modifier form.
• ❗ - Line 80, Col 7 - Style/CommentedKeyword - Do not place comments on the same line as the end keyword.
• ❗ - Line 84, Col 35 - Layout/SpaceAroundEqualsInParameterDefault - Surrounding space missing in default value assignment.
• ❗ - Line 85, Col 19 - Style/UnneededInterpolation - Prefer to_s over string interpolation.
• ❗ - Line 86, Col 40 - Style/UnneededInterpolation - Prefer to_s over string interpolation.
• ❗ - Line 96, Col 12 - Style/RescueModifier - Avoid using rescue in its modifier form.

content/automate/ManageIQ/Infrastructure/VM/Provisioning/StateMachines/Methods.class/methods/redhat_customizerequest.rb

• ⚠️ - Line 118, Col 3 - Lint/EmptyWhen - Avoid when branches without a body.
• ⚠️ - Line 127, Col 45 - Lint/UnusedMethodArgument - Unused method argument - product. If it's necessary, use _ or _product as an argument name to indicate that it won't be used.
• ⚠️ - Line 127, Col 54 - Lint/UnusedMethodArgument - Unused method argument - provider. If it's necessary, use _ or _provider as an argument name to indicate that it won't be used.
• ⚠️ - Line 130, Col 3 - Lint/EmptyWhen - Avoid when branches without a body.
• ⚠️ - Line 164, Col 3 - Lint/EmptyWhen - Avoid when branches without a body.
• ⚠️ - Line 17, Col 58 - Lint/UnusedMethodArgument - Unused method argument - provider. If it's necessary, use _ or _provider as an argument name to indicate that it won't be used.
• ⚠️ - Line 20, Col 3 - Lint/EmptyWhen - Avoid when branches without a body.
• ⚠️ - Line 67, Col 3 - Lint/EmptyWhen - Avoid when branches without a body.
• ⚠️ - Line 76, Col 58 - Lint/UnusedMethodArgument - Unused method argument - provider. If it's necessary, use _ or _provider as an argument name to indicate that it won't be used.
• ⚠️ - Line 79, Col 3 - Lint/EmptyWhen - Avoid when branches without a body.
• ❗ - Line 105, Col 105 - Layout/SpaceAroundOperators - Surrounding space missing for operator ==.
• ❗ - Line 121, Col 3 - Style/EmptyElse - Redundant else-clause.
• ❗ - Line 12, Col 3 - Style/RescueModifier - Avoid using rescue in its modifier form.
• ❗ - Line 134, Col 52 - Style/RescueModifier - Avoid using rescue in its modifier form.
• ❗ - Line 13, Col 70 - Style/RescueModifier - Avoid using rescue in its modifier form.
• ❗ - Line 143, Col 118 - Layout/SpaceAroundOperators - Surrounding space missing for operator ==.
• ❗ - Line 150, Col 147 - Layout/SpaceAroundOperators - Surrounding space missing for operator ==.
• ❗ - Line 157, Col 9 - Style/RescueModifier - Avoid using rescue in its modifier form.
• ❗ - Line 166, Col 3 - Style/EmptyElse - Redundant else-clause.
• ❗ - Line 179, Col 12 - Style/RescueModifier - Avoid using rescue in its modifier form.
• ❗ - Line 29, Col 94 - Layout/SpaceAroundOperators - Surrounding space missing for operator ==.
• ❗ - Line 42, Col 103 - Layout/SpaceAroundOperators - Surrounding space missing for operator ==.
• ❗ - Line 54, Col 90 - Layout/SpaceAroundOperators - Surrounding space missing for operator ==.
• ❗ - Line 61, Col 103 - Layout/SpaceAroundOperators - Surrounding space missing for operator ==.
• ❗ - Line 6, Col 35 - Layout/SpaceAroundEqualsInParameterDefault - Surrounding space missing in default value assignment.
• ❗ - Line 70, Col 3 - Style/EmptyElse - Redundant else-clause.
• ❗ - Line 72, Col 7 - Style/CommentedKeyword - Do not place comments on the same line as the end keyword.
• ❗ - Line 73, Col 5 - Style/CommentedKeyword - Do not place comments on the same line as the end keyword.
• ❗ - Line 7, Col 19 - Style/UnneededInterpolation - Prefer to_s over string interpolation.
• ❗ - Line 87, Col 60 - Style/RescueModifier - Avoid using rescue in its modifier form.
• ❗ - Line 88, Col 92 - Layout/SpaceAroundOperators - Surrounding space missing for operator ==.
• ❗ - Line 8, Col 40 - Style/UnneededInterpolation - Prefer to_s over string interpolation.

content/automate/ManageIQ/Infrastructure/VM/Provisioning/StateMachines/Methods.class/methods/redhat_preprovision.rb

• ❗ - Line 6, Col 19 - Style/UnneededInterpolation - Prefer to_s over string interpolation.
• ❗ - Line 7, Col 40 - Style/UnneededInterpolation - Prefer to_s over string interpolation.

content/automate/ManageIQ/Infrastructure/VM/Provisioning/StateMachines/Methods.class/methods/vmware_customizerequest.rb

• ⚠️ - Line 120, Col 3 - Lint/EmptyWhen - Avoid when branches without a body.
• ⚠️ - Line 18, Col 35 - Lint/UnusedMethodArgument - Unused method argument - template. If it's necessary, use _ or _template as an argument name to indicate that it won't be used.
• ⚠️ - Line 18, Col 54 - Lint/UnusedMethodArgument - Unused method argument - provider. If it's necessary, use _ or _provider as an argument name to indicate that it won't be used.
• ⚠️ - Line 26, Col 3 - Lint/EmptyWhen - Avoid when branches without a body.
• ⚠️ - Line 61, Col 3 - Lint/EmptyWhen - Avoid when branches without a body.
• ⚠️ - Line 70, Col 58 - Lint/UnusedMethodArgument - Unused method argument - provider. If it's necessary, use _ or _provider as an argument name to indicate that it won't be used.
• ⚠️ - Line 73, Col 3 - Lint/EmptyWhen - Avoid when branches without a body.
• ❗ - Line 123, Col 3 - Style/EmptyElse - Redundant else-clause.
• ❗ - Line 124, Col 3 - Layout/CommentIndentation - Incorrect indentation detected (column 2 instead of 4).
• ❗ - Line 125, Col 7 - Style/CommentedKeyword - Do not place comments on the same line as the end keyword.
• ❗ - Line 126, Col 5 - Style/CommentedKeyword - Do not place comments on the same line as the end keyword.
• ❗ - Line 12, Col 3 - Style/RescueModifier - Avoid using rescue in its modifier form.
• ❗ - Line 135, Col 12 - Style/RescueModifier - Avoid using rescue in its modifier form.
• ❗ - Line 13, Col 70 - Style/RescueModifier - Avoid using rescue in its modifier form.
• ❗ - Line 156, Col 1 - Layout/CommentIndentation - Incorrect indentation detected (column 0 instead of 2).
• ❗ - Line 171, Col 1 - Layout/CommentIndentation - Incorrect indentation detected (column 0 instead of 2).
• ❗ - Line 19, Col 1 - Layout/CommentIndentation - Incorrect indentation detected (column 0 instead of 2).
• ❗ - Line 30, Col 3 - Layout/CommentIndentation - Incorrect indentation detected (column 2 instead of 4).
• ❗ - Line 64, Col 3 - Style/EmptyElse - Redundant else-clause.
• ❗ - Line 65, Col 3 - Layout/CommentIndentation - Incorrect indentation detected (column 2 instead of 4).
• ❗ - Line 66, Col 7 - Style/CommentedKeyword - Do not place comments on the same line as the end keyword.
• ❗ - Line 67, Col 5 - Style/CommentedKeyword - Do not place comments on the same line as the end keyword.
• ❗ - Line 7, Col 19 - Style/UnneededInterpolation - Prefer to_s over string interpolation.
• ❗ - Line 81, Col 59 - Style/RescueModifier - Avoid using rescue in its modifier form.
• ❗ - Line 94, Col 68 - Style/RescueModifier - Avoid using rescue in its modifier form.

content/automate/ManageIQ/Infrastructure/VM/Provisioning/StateMachines/Methods.class/methods/vmware_preprovision.rb

• ❗ - Line 20, Col 10 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 20, Col 12 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• ❗ - Line 35, Col 7 - Layout/LeadingCommentSpace - Missing space after #.
• ❗ - Line 38, Col 7 - Layout/LeadingCommentSpace - Missing space after #.
• ❗ - Line 6, Col 19 - Style/UnneededInterpolation - Prefer to_s over string interpolation.
• ❗ - Line 7, Col 40 - Style/UnneededInterpolation - Prefer to_s over string interpolation.

content/automate/ManageIQ/Infrastructure/VM/Provisioning/StateMachines/Methods.class/methods/vmware_preprovision_clone_to_template.rb

• ❗ - Line 22, Col 12 - Style/RescueModifier - Avoid using rescue in its modifier form.
• ❗ - Line 72, Col 31 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 84, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.

content/automate/ManageIQ/Infrastructure/VM/Provisioning/StateMachines/Methods.class/methods/vmware_preprovision_clone_to_vm.rb

• ❗ - Line 104, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 25, Col 12 - Style/RescueModifier - Avoid using rescue in its modifier form.
• ❗ - Line 28, Col 1 - Layout/EmptyLines - Extra blank line detected.
• ❗ - Line 39, Col 3 - Style/UnlessElse - Do not use unless with else. Rewrite these with the positive case first.
• ❗ - Line 92, Col 31 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].

[coveralls]

Pull Request Test Coverage Report for Build 4075

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.01%) to 97.388%

---

Totals
Change from base Build 4073:	0.01%
Covered Lines:	3020
Relevant Lines:	3101

---

💛 - Coveralls

[lfu]

It looks good. Just wondering if there is any existing tests for these methods.

[billfitzgerald0120]

It looks good. Just wondering if there is any existing tests for these methods.

There are no existing specs. The replaced methods only had a log message.

[tinaafitz]

Hi @pkomanek Can you refactor the 8 methods included in this PR, and add spec tests?

[pkomanek]

Hi @tinaafitz. Sure.