Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an automate event for DrsMigrateVM_Task #625

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

agrare
Copy link
Member

@agrare agrare commented Jan 7, 2020

This adds an automate event instance for the DrsMigrateVM_Task event
which is a more specific subclass of the MigrateVM_Task class.

https://bugzilla.redhat.com/show_bug.cgi?id=1788540

This adds an automate event instance for the DrsMigrateVM_Task event
which is a more specific subclass of the MigrateVM_Task class.

https://bugzilla.redhat.com/show_bug.cgi?id=1788540
@miq-bot
Copy link
Member

miq-bot commented Jan 7, 2020

Checked commit agrare@fbca988 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@coveralls
Copy link

coveralls commented Jan 7, 2020

Pull Request Test Coverage Report for Build 4095

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.389%

Totals Coverage Status
Change from base Build 4092: 0.0%
Covered Lines: 3021
Relevant Lines: 3102

💛 - Coveralls

@lfu
Copy link
Member

lfu commented Jan 7, 2020

We could either add DrsMigrateVM_Task or add the policy call to existing event DrsMigrateVM_Task_Complete.

@gmcculloug which way would be better?

@agrare
Copy link
Member Author

agrare commented Jan 7, 2020

So I went with this because it mirrors the MigrateVM_Task behavior, I thought it'd be confusing if things were different between a manual migration and an automated DRS migration.

@lfu
Copy link
Member

lfu commented Jan 7, 2020

@agrare Sounds good to me.

Copy link
Member

@gmcculloug gmcculloug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we should keep it similar to the MigrateVM_Task event. I think this way would allow for the ability to cancel the task from policy if needed. Users could always override this and the DrsMigrateVM_Task_Complete event if they really needed to switch the logic.

@gmcculloug gmcculloug self-assigned this Jan 7, 2020
@gmcculloug gmcculloug merged commit 1196ecc into ManageIQ:master Jan 7, 2020
@gmcculloug gmcculloug added this to the Sprint 128 Ending Jan 20, 2020 milestone Jan 7, 2020
@agrare agrare deleted the add_drs_migrate_vm_task_event branch January 7, 2020 17:11
@agrare
Copy link
Member Author

agrare commented Jan 7, 2020

Thanks @gmcculloug , I'll leave it up to you if you think this is enough to consider the BZ "fixed"

@simaishi
Copy link
Contributor

@agrare @gmcculloug can this be hammer/yes?

simaishi pushed a commit that referenced this pull request Jan 28, 2020
Add an automate event for DrsMigrateVM_Task

(cherry picked from commit 1196ecc)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1794573
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit fce92275b1ba8c1cc5a08512cf2ca1cc8ff52ff0
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Tue Jan 7 12:11:23 2020 -0500

    Merge pull request #625 from agrare/add_drs_migrate_vm_task_event

    Add an automate event for DrsMigrateVM_Task

    (cherry picked from commit 1196ecced601c9729c4c74335d212460470b7333)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1794573

simaishi pushed a commit that referenced this pull request Feb 21, 2020
Add an automate event for DrsMigrateVM_Task

(cherry picked from commit 1196ecc)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1794574
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit 9f958b91a78c18eadf6ef1497e81cbc7c34d37f7
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Tue Jan 7 12:11:23 2020 -0500

    Merge pull request #625 from agrare/add_drs_migrate_vm_task_event

    Add an automate event for DrsMigrateVM_Task

    (cherry picked from commit 1196ecced601c9729c4c74335d212460470b7333)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1794574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants