Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added method instances for EmbeddedAnsible #80

Merged
merged 1 commit into from Mar 30, 2017
Merged

Added method instances for EmbeddedAnsible #80

merged 1 commit into from Mar 30, 2017

Conversation

mkanoor
Copy link
Contributor

@mkanoor mkanoor commented Mar 29, 2017

@mkanoor mkanoor added the bug label Mar 29, 2017
@mkanoor mkanoor requested a review from gmcculloug March 29, 2017 19:34
@gmcculloug
Copy link
Member

@mkanoor Are there related tests that should be updated to reflect this change?

@mkanoor mkanoor changed the title AnsibleTower should have been EmbeddedAnsible Added method instances for EmbeddedAnsible Mar 29, 2017
@miq-bot
Copy link
Member

miq-bot commented Mar 29, 2017

Checked commit mkanoor@8ff65b8 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 🍪

@mkanoor mkanoor mentioned this pull request Mar 29, 2017
Merged
@gmcculloug gmcculloug merged commit 87d29ca into ManageIQ:master Mar 30, 2017
@gmcculloug gmcculloug added this to the Sprint 58 Ending Apr 10, 2017 milestone Mar 30, 2017
simaishi pushed a commit that referenced this pull request Mar 30, 2017
@gmcculloug @simaishi
Merge pull request #80 from mkanoor/bz_1436717
f5ac67c 
Added method instances for EmbeddedAnsible
(cherry picked from commit 87d29ca)

https://bugzilla.redhat.com/show_bug.cgi?id=1437597
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit f5ac67c86dddfab4ff346cd66953ed5a39637ac0
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Thu Mar 30 09:27:32 2017 -0400

    Merge pull request #80 from mkanoor/bz_1436717
    
    Added method instances for EmbeddedAnsible
    (cherry picked from commit 87d29caf9be17ba202a4b09443f31aa7b6a6a535)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1437597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmcculloug gmcculloug Awaiting requested review from gmcculloug

Assignees

@gmcculloug gmcculloug

Labels
bug fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mkanoor @gmcculloug @miq-bot @simaishi