Changed ${/#ae_reason} to a string value in on_error methods. #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed all occurrences in class schemas and instances. https://bugzilla.redhat.com/show_bug.cgi?id=1439845
|
@billfitzgerald0120 Cannot apply the following label because they are not recognized: fine/yes euwe/yes |
|
@miq-bot add_label fine/yes, euwe/yes |
tinaafitz
reviewed
Apr 20, 2017
| @@ -148,7 +148,7 @@ object: | |||
| condition: | |||
| on_entry: update_serviceprovision_status(status => 'Creating Stack') | |||
| on_exit: update_serviceprovision_status(status => 'Creating Stack') | |||
| on_error: update_serviceprovision_status(status => '${/#ae_reason}') | |||
| on_error: update_serviceprovision_status(status => 'Error Provisioning Stack') | |||
There was a problem hiding this comment.
@billfitzgerald0120 Can we change the status to 'Error Creating Stack'?
tinaafitz
reviewed
Apr 20, 2017
| @@ -168,7 +168,7 @@ object: | |||
| condition: | |||
| on_entry: | |||
| on_exit: update_serviceprovision_status(status => 'Creating Stack') | |||
| on_error: update_serviceprovision_status(status => '${/#ae_reason}') | |||
| on_error: update_serviceprovision_status(status => 'Error Provisioning Stack') | |||
There was a problem hiding this comment.
@billfitzgerald0120 Can we change the status to 'Error Creating Stack'?
tinaafitz
reviewed
Apr 20, 2017
| @@ -208,7 +208,7 @@ object: | |||
| condition: | |||
| on_entry: | |||
| on_exit: update_provision_status(status => 'Creating VM') | |||
| on_error: update_provision_status(status => '${/#ae_reason}') | |||
| on_error: update_provision_status(status => 'Error Provisioning Instance') | |||
There was a problem hiding this comment.
@billfitzgerald0120 Can we change the status to 'Error Creating VM'?
|
Made changes as requested. |
|
Checked commits billfitzgerald0120/manageiq-content@1a5c457~...595a237 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@billfitzgerald0120 Looks good. |
mkanoor
approved these changes
May 4, 2017
|
Euwe backport (to manageiq repo) details: |
simaishi
pushed a commit
that referenced
this pull request
Jun 6, 2017
Changed ${/#ae_reason} to a string value in on_error methods.
(cherry picked from commit b92d4a4)
https://bugzilla.redhat.com/show_bug.cgi?id=1459260
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed all occurrences in class schemas and instances.
https://bugzilla.redhat.com/show_bug.cgi?id=1439845
@miq-bot add_label bug, fine/yes euwe/yes