Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate methods #3

Merged
merged 2 commits into from Apr 23, 2019
Merged

Conversation

martinpovolny
Copy link
Member

@martinpovolny martinpovolny commented Mar 15, 2019

Part of: ManageIQ/manageiq-ui-classic#5295

I have actually tested only one of the 2. Looking how to get test data. (@lfu tested it)

@martinpovolny martinpovolny changed the title Automate methods [WIP] Automate methods Mar 15, 2019
@epwinchell
Copy link
Contributor

@miq-bot add_reviewer @epwinchell

@martinpovolny martinpovolny changed the title [WIP] Automate methods Automate methods Apr 19, 2019
@martinpovolny
Copy link
Member Author

replaced with 'ff ff-load-balancer' according to @lfu 's testing : ManageIQ/manageiq-ui-classic#5295

@martinpovolny
Copy link
Member Author

ping @skateman

@skateman
Copy link
Member

@martinpovolny can you provide us some screenshots so we can see this with @epwinchell?

@martinpovolny
Copy link
Member Author

No. I cannot (as I wrote above).

@lfu, can you, please, make a pretty picture for @skateman ?

@martinpovolny
Copy link
Member Author

martinpovolny commented Apr 19, 2019

picture with one of the icons is here:

icons

(from ManageIQ/manageiq-ui-classic#5295)

@lfu
Copy link
Member

lfu commented Apr 22, 2019

Screen Shot 2019-04-22 at 10 05 33

@epwinchell
Copy link
Contributor

epwinchell commented Apr 22, 2019

test_template_method doesn't seem to be using ff-method:

Screen Shot 2019-04-22 at 10 09 55 AM

@martinpovolny Should it be?

@epwinchell epwinchell self-requested a review April 22, 2019 14:20
@lfu
Copy link
Member

lfu commented Apr 22, 2019

test_template_method is an instance. test_workflow_template is a workflow template method.

@skateman skateman merged commit fbb4695 into ManageIQ:master Apr 23, 2019
@epwinchell epwinchell removed the wip label May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants