Dup strings in case they're frozen before force_encoding #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commits https://github.com/djberg96/manageiq-gems-pending/compare/2dbc22dbefb4b5f7e87398722f81f9d54e975a80~...884a97d7658bc3bb944e85ffe764e38a24a3bfba with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@djberg96 'roliveri jerryk55' is an invalid reviewer, ignoring... |
|
@djberg96 'roliveri, jerryk55' is an invalid reviewer, ignoring... |
|
@miq-bot add_label bug, ivanchuk/yes |
|
@djberg96 'jerryk55' is an invalid reviewer, ignoring... |
|
Well, in that I'm "invalid", I approve regardless.... :-) |
roliveri
approved these changes
Aug 30, 2019
simaishi
pushed a commit
that referenced
this pull request
Sep 3, 2019
Dup strings in case they're frozen before force_encoding (cherry picked from commit c84fb58) https://bugzilla.redhat.com/show_bug.cgi?id=1535782
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
force_encodingon a frozen string will bomb. This dups the string first before calling it.This was already being done at https://github.com/ManageIQ/manageiq-gems-pending/blob/master/lib/gems/pending/util/xml/miq_rexml.rb#L288.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1535782