Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aws targetted and full refresh specs for ebs storage manager #185

Conversation

Ladas
Copy link
Contributor

@Ladas Ladas commented Mar 17, 2017

Depends on:

Aws targetted and full refresh specs for ebs storage manager

@Ladas Ladas mentioned this pull request Mar 17, 2017
1 task
Add EbsStorageManager to VCR specs
Refresh VCRs after adding EbsStorageManager to specs
@Ladas Ladas force-pushed the aws_targetted_and_full_refresh_specs_for_ebs_storage_manager branch from 1d90d4b to a42ba7a Compare March 17, 2017 10:57
Change the specs after refreshing VCRs, also new storate data
combination was added to the VCR envs.
@Ladas Ladas force-pushed the aws_targetted_and_full_refresh_specs_for_ebs_storage_manager branch from a42ba7a to 83aa52a Compare March 17, 2017 11:01
@miq-bot
Copy link
Member

miq-bot commented Mar 17, 2017

Some comments on commits Ladas/manageiq-providers-amazon@5e76f25~...83aa52a

spec/vcr_cassettes/manageiq/providers/amazon/cloud_manager/refresher.yml

  • 💣 💥 🔥 🚒 - 14670 - Detected cfme

spec/vcr_cassettes/manageiq/providers/amazon/cloud_manager/refresher_inventory_object.yml

  • 💣 💥 🔥 🚒 - 12009 - Detected cfme

@miq-bot
Copy link
Member

miq-bot commented Mar 17, 2017

Checked commits Ladas/manageiq-providers-amazon@5e76f25~...83aa52a with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
5 files checked, 0 offenses detected
Everything looks good. 👍

Copy link
Member

@durandom durandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay, I knew what this did in < 1.minute

🙇

@durandom durandom merged commit 095efc2 into ManageIQ:master Mar 17, 2017
@durandom durandom added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants