New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gettext catalog to ManageIQ::Providers::Amazon plugin #28
Add gettext catalog to ManageIQ::Providers::Amazon plugin #28
Conversation
@mzazrivec can we do without the colon |
@@ -3,6 +3,12 @@ module Providers | |||
module Amazon | |||
class Engine < ::Rails::Engine | |||
isolate_namespace ManageIQ::Providers::Amazon | |||
|
|||
config.to_prepare do | |||
Vmdb::Gettext::Domains.add_domain('ManageIQ::Providers::Amazon', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we move this to an initializer?
@durandom You mean the file names like Yes, when we create the catalog, we can replace |
5dd6032
to
1bf5b95
Compare
In case we already have colons in files on miq side, its ok. |
@durandom We don't have I also moved the initialization code into initializer ( |
…lugin The catalog was generated automatically by invoking the following rake task in the ManageIQ git checkout: rake locale:plugin:find[ManageIQ::Providers::Amazon]
This way the provider plugin makes the fast_gettext engine aware of the plugin's gettext catalog.
1bf5b95
to
df89a26
Compare
@durandom I fixed both the thing with initialization and the file paths. |
Checked commits mzazrivec/manageiq-providers-amazon@4de7a0f~...df89a26 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 config/initializers/gettext.rb
|
Changes:
ManageIQ::Providers::Amazon
provider plugin. The catalog wasgenerated automatically by invoking the following rake task in the ManageIQ git checkout:
ManageIQ::Providers::Amazon
plugin now registers its own catalog with the main ManageIQrails app. This way the provider plugin makes the fast_gettext engine aware of the plugin's gettext catalog.