[WIP] Collect instance types from the API #582
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
force-pushed
the
bz_1781155_dynamically_collect_aws_instance_types
branch
2 times, most recently
from
43b254e
to
b15f2c3
Compare
|
Checked commit agrare@b15f2c3 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
djberg96
reviewed
Dec 19, 2019
| @@ -4,7 +4,7 @@ def instances | |||
| end | |||
|
|
|||
| def flavors | |||
| ManageIQ::Providers::Amazon::InstanceTypes.all | |||
| hash_collection.new(aws_ec2.client.describe_instance_types[:instance_types]) | |||
There was a problem hiding this comment.
Any filters we should apply here? Do we want to cap the results? Just checking:
There was a problem hiding this comment.
No need to cap the results, but we do need to handle paging generally. That is out of scope of this PR since that is a general issue with all of these API calls. I opened an issue to track that, #583
There was a problem hiding this comment.
So then it just becomes hash_collection.new(aws_ec2.client.describe_instance_types.flat_map(&:instance_types))
|
Superseded by #614 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1781155