Add DDF based verify_credentials #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 tasks
agrare
reviewed
Oct 1, 2019
|
Just the verify_ssl issue, then this works in the success and failure case for both the provider and automation_manager 馃憤 |
|
Also the base_url wouldn't work unless it was in the |
Fryguy
force-pushed
the
add_ddf_based_verify_credentials
branch
from
1e457fb
to
4b2ee81
Compare
agrare
approved these changes
Oct 1, 2019
Fryguy
force-pushed
the
add_ddf_based_verify_credentials
branch
from
4b2ee81
to
45042c5
Compare
|
@agrare Updated with the base_url handling |
Fryguy
changed the title
|
Checked commit 45042c5 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of ManageIQ/manageiq#18818
Completely untested, but since this is my first, want to get some 馃崊 thrown at it. @agrare Please review.