[wip] Collect variable tower data #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Do not use removed credential kinds: Azure (Classic) and Rackspace. Additional touches include: * Rename Satelite6 credential variable. * Fix code style by removing unnecessary spaces.
Glutexo
force-pushed
the
collect_variable_tower_data
branch
4 times, most recently
from
42bffd1
to
5b7c2c0
Compare
|
Fixed newly introduced RuboCop and Codeclimate offenses and rebased. |
Glutexo
force-pushed
the
collect_variable_tower_data
branch
4 times, most recently
from
ee24722
to
e53e694
Compare
Glutexo
force-pushed
the
collect_variable_tower_data
branch
from
e53e694
to
fc948d7
Compare
|
Added |
There is a rake task that populates Tower with test data. This data is used to record VCR cassettes. Unfortunately some specs used some other unknown Tower entities instead of the created ones. Unify the specs to use the entities created by the populate Rake task. Re-record cassettes using a non-blank Tower 3.2.2 test instance.
It may not be possible to create a job template right after creating a project that the template uses. Add a try-wait loop that ensures that the project has been created in Tower and it successfully finished cloning. In case of clone failure, raise an error. If the project is not ready yet, wait a bit and try again. The number of tries is limited, raising an error on depletion. Extract the del_object sleep as a class constant for symmetry.
Each time objects are populated in a Tower instance, some of their properties (ids, timestamps…) change. The same applies to objects counts that can differ from the previous state. This required manual update of expectation in specs when re-recording VCR cassettes. Collect these changing data during their population in Tower instance to a YAML file. Use this information in specs instead of magic literals. This allows to re-record the cassettes without breaking the tests and removes the need to manually edit the expectations in the specs.
Glutexo
force-pushed
the
collect_variable_tower_data
branch
from
fc948d7
to
11bafce
Compare
|
Some comments on commits Glutexo/manageiq-providers-ansible_tower@940342b~...11bafce lib/tasks_private/spec_helper.rake
|
|
Checked commits Glutexo/manageiq-providers-ansible_tower@940342b~...11bafce with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 lib/tasks_private/spec_helper.rake
|
Glutexo
changed the title
This was referenced May 29, 2018
|
Broken down to smaller parts to make review easier:
This does not completely replace the original PR as some merges will be required. There are however only few missing bits that will come in further PRs after merging. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each time objects are populated in a Tower instance, some of their properties (ids, timestamps…) change. The same applies to objects counts that can differ from the previous state. This required manual update of expectation in specs when re-recording VCR cassettes.
Collect these changing data during their population in Tower instance to a YAML file. Use this information in specs instead of magic literals. This allows to re-record the cassettes without breaking the tests and removes the need to manually edit the expectations in the specs.
This PR is based on #73 and requires it to be merged before. The referenced PR fixes the specs so their expectations do not requirer other objects in Tower instance than those populated by the Rake task.
CC @jameswnl for review.