storage manager volume create: basic and advanced modes #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrGur1987
requested review from
agrare,
Fryguy,
ereztheodorou,
erantzabari,
llivne and
gregoryb-at-ibm
as code owners
OrGur1987
force-pushed
the
326048_add_capabilities_for_create_volume
branch
5 times, most recently
from
052e6b7
to
8248d32
Compare
|
Hey @OrGur1987 can you include an example of what the capabilities json looks like? |
edited description |
OrGur1987
force-pushed
the
326048_add_capabilities_for_create_volume
branch
5 times, most recently
from
fd77bcc
to
ae04dc0
Compare
OrGur1987
changed the title
|
Hi @agrare tests are successful, it's ready for a review, thanks |
agrare
reviewed
Jan 11, 2023
| ) | ||
| } | ||
|
|
||
| if options['mode'] == 'Basic' |
There was a problem hiding this comment.
Where is options['mode'] coming from? I don't see it in the DDF params
There was a problem hiding this comment.
it used to be in cloud-volume-form.schema.js but I moved it to cloud_voume.rb following @Fryguy's request:
ManageIQ/manageiq-ui-classic#8582 (comment)
agrare
reviewed
Jan 11, 2023
agrare
reviewed
Jan 11, 2023
app/models/manageiq/providers/autosde/storage_manager/cloud_volume.rb
Outdated
Show resolved
Hide resolved
agrare
reviewed
Jan 11, 2023
app/models/manageiq/providers/autosde/storage_manager/cloud_volume.rb
Outdated
Show resolved
Hide resolved
agrare
reviewed
Jan 11, 2023
app/models/manageiq/providers/autosde/storage_manager/cloud_volume.rb
Outdated
Show resolved
Hide resolved
- Basic: choose an existing service - Advanced: choose a name for a new service and choose existing resources to attach to it
OrGur1987
force-pushed
the
326048_add_capabilities_for_create_volume
branch
from
ae04dc0
to
f1208cc
Compare
|
Checked commit Autosde@f1208cc with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
agrare
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filter services and resources by capabilities on volume create:
Basic: filter services by required capabilities and choose an existing service from the filtered list.
Advanced: choose a name for a new service, filter resources by required capabilities, and choose resources to attach to the new service from the filtered list. the new volume(s) will be created for the new service, on one of the attached resources.
changes:
related PR in ui-classic:
ManageIQ/manageiq-ui-classic#8582