Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump azure-armrest dependency to 0.8.2 #120

Merged
merged 1 commit into from Sep 5, 2017
Merged

Bump azure-armrest dependency to 0.8.2 #120

merged 1 commit into from Sep 5, 2017

Conversation

djberg96
Copy link
Collaborator

The 0.8.2 release contains some important bug fixes and features. We should upgrade.

https://github.com/ManageIQ/azure-armrest/blob/master/CHANGES#L1-L16

@djberg96
Copy link
Collaborator Author

@miq-bot add_label fine/yes

@djberg96
Copy link
Collaborator Author

@miq-bot add_label euwe/yes

@miq-bot
Copy link
Member

miq-bot commented Aug 30, 2017

Checked commit https://github.com/djberg96/manageiq-providers-azure/commit/4cd815132d920bd08be0b3d57b61be5b11285b88 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@bronaghs bronaghs merged commit 91afa86 into ManageIQ:master Sep 5, 2017
@simaishi
Copy link
Contributor

simaishi commented Sep 5, 2017

Marking as blocker (for Fine branch) as https://bugzilla.redhat.com/show_bug.cgi?id=1475540 needs this change.

@djberg96 I don't see any BZs associated for Euwe branch backport. Does this fix any BZ for Euwe branch?

@djberg96
Copy link
Collaborator Author

djberg96 commented Sep 5, 2017

@simaishi Not explicitly, but I like to keep the branches in sync if possible.

@simaishi
Copy link
Contributor

simaishi commented Sep 5, 2017

@djberg96 Changes going to non-master branch requires a BZ, marking as bugzilla needed

@simaishi
Copy link
Contributor

simaishi commented Sep 6, 2017

Also a note: Fine branch is using 0.7.4 and Euwe is using 0.7.3. So this update is going to pick up all changes made after those versions in each branch, not just 0.8.1 -> 0.8.2 changes. That's one more reason a BZ is needed for, as we should identify what changed and see if anything should be specifically tested.

jerryk55 added a commit to jerryk55/manageiq-gems-pending that referenced this pull request Sep 6, 2017
Remove the change to the gemspec bumping up azure-armrest to 0.8.2
and reset to 0.7.0.
Allow PR ManageIQ/manageiq-providers-azure#120
to handle this change.
@djberg96
Copy link
Collaborator Author

djberg96 commented Sep 6, 2017

@simaishi I'll just remove the euwe label for now. Please proceed with the fine backport.

@djberg96
Copy link
Collaborator Author

djberg96 commented Sep 6, 2017

@miq-bot remove_label euwe/yes

@simaishi
Copy link
Contributor

simaishi commented Sep 6, 2017

Fine backport (to manageiq-gems-pending repo) details:

$ git log -1
commit db8dadd367cd34e7d7acc1d95f5637e6c1edb224
Author: Bronagh Sorota <bsorota@redhat.com>
Date:   Tue Sep 5 10:01:05 2017 -0400

    Merge pull request #120 from djberg96/gemspec
    
    Bump azure-armrest dependency to 0.8.2
    (cherry picked from commit 91afa868336b337fd2d73bd8de8e44c3b20c4d4f)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1488967

simaishi pushed a commit that referenced this pull request Sep 6, 2017
Bump azure-armrest dependency to 0.8.2
(cherry picked from commit 91afa86)

https://bugzilla.redhat.com/show_bug.cgi?id=1488967
@simaishi
Copy link
Contributor

simaishi commented Sep 6, 2017

Fine backport details:

$ git log -1
commit 8154df65c75616bdeda9f13d4972edbeaacbcfaa
Author: Bronagh Sorota <bsorota@redhat.com>
Date:   Tue Sep 5 10:01:05 2017 -0400

    Merge pull request #120 from djberg96/gemspec
    
    Bump azure-armrest dependency to 0.8.2
    (cherry picked from commit 91afa868336b337fd2d73bd8de8e44c3b20c4d4f)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1488967

@simaishi
Copy link
Contributor

simaishi commented Sep 6, 2017

Backported to manageiq-providers-azure.gemspec as well as manageiq-gems-pending.gemspec for Fine branch, as azure-armrest gem is in 2 places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants