Smart state Snapshot Managed Disk Name 80 Char Limit #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes required since there is an 80 character limit on the name of the snapshot for a managed disk - 1) Use the VM name instead of the OS DIsk name. 2) Shorten the suffix for the snapshot from 20 to 13 characters. 3) If the above is still longer than 80 characters truncate the VM name to 80-13 characters. 4) Always pass the snapshot name to MiqAzureVm so that it does not have to compute the name as well.
|
@miq-bot add_label fine/yes |
|
@miq-bot add_label gaprindashvili/yes |
|
@miq-bot add_label bug |
|
@miq-bot add_label "smart state" |
|
@jerryk55 Cannot apply the following label because they are not recognized: "smart state" |
|
Checked commit jerryk55@9a1b8d3 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Will we need to migrate existing data? |
|
@djberg96 no - the snapshot is removed after the Smartstate scan is finished. So any old names shouldn't exist anymore. |
|
ok, LGTM. 👍 |
simaishi
pushed a commit
that referenced
this pull request
Nov 7, 2017
…60chars Smart state Snapshot Managed Disk Name 80 Char Limit (cherry picked from commit e6d33b9)
|
Gaprindashvili backport details: |
simaishi
pushed a commit
that referenced
this pull request
Nov 14, 2017
…60chars Smart state Snapshot Managed Disk Name 80 Char Limit (cherry picked from commit e6d33b9) https://bugzilla.redhat.com/show_bug.cgi?id=1512967
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes required since there is an 80 character limit on the name
of the snapshot for a managed disk -
as well.
This PR goes hand-in-hand with ManageIQ/manageiq-smartstate#44 which receives the name of the snapshot to use when communicating with Azure. Both PRs fix the issue https://bugzilla.redhat.com/show_bug.cgi?id=1508577.
The two PRs can be merged in any order. The GEMfile for this provider must be updated after the smartstate gem is updated.
This PR should be back ported to both FINE and Gaprindashvili.
@roliveri @hsong-rh @bronaghs @djberg96 please review and merge. Thanks.