Update armrest version to 0.7.0 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label euwe/yes |
|
@miq-bot add_label darga/yes |
|
I think this will fail until ManageIQ/manageiq-gems-pending#100 is merged. |
Update flavor count and refresher cassettes. Updated for latest api-version change.
|
Checked commit https://github.com/djberg96/manageiq-providers-azure/commit/ba881682a2451d6ed4ac042f7e521441c48a1d06 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@miq-bot add_label fine/yes |
simaishi
pushed a commit
that referenced
this pull request
Mar 31, 2017
Update armrest version to 0.7.0 (cherry picked from commit c318b5d) https://bugzilla.redhat.com/show_bug.cgi?id=1438092
|
Fine backport details: |
|
@djberg96 Can you please create an Euwe PR for this PR and ManageIQ/manageiq-gems-pending#100 combined? |
|
@simaishi Ok, please see ManageIQ/manageiq#14799 |
|
Backported to Euwe via ManageIQ/manageiq#14799 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the azure-armrest version up to 0.7.0.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1434988
The major version changes shouldn't be scary. The change from 0.5.x to 0.6.x was caused by an incompatible change to Role classes that we don't use internally. The change from 0.6.x to 0.7.x is the backwards incompatible, but necessary, change for getting templates.
Other than a redundant
.to_scall, there should be no issues on the ManageIQ side.