Skip to content

Commit

Permalink
Merge pull request #5 from lgalis/manager_name_not_updated_on_provide…
Browse files Browse the repository at this point in the history
…r_edit

Manager name not updated on foreman provider edit
  • Loading branch information
gmcculloug committed Jul 5, 2017
2 parents ed92271 + 0a84fe3 commit 1fd7717
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
2 changes: 1 addition & 1 deletion app/models/manageiq/providers/foreman/provider.rb
Expand Up @@ -20,7 +20,7 @@ class ManageIQ::Providers::Foreman::Provider < ::Provider

delegate :api_cached?, :ensure_api_cached, :to => :connect

before_create :ensure_managers
before_validation :ensure_managers

validates :name, :presence => true, :uniqueness => true
validates :url, :presence => true
Expand Down
11 changes: 11 additions & 0 deletions spec/models/manageiq/providers/foreman/provider_spec.rb
Expand Up @@ -58,4 +58,15 @@
expect(CustomizationScript.count).to eq(0)
end
end

describe "#save" do
it "will update the name for the manager" do
provider = FactoryGirl.create(:provider_foreman, :zone => FactoryGirl.create(:zone), :name => 'Old Name')
expect(provider.configuration_manager.name).to eq('Old Name Configuration Manager')

provider.update(:name => 'New Name')
expect(provider.configuration_manager.name).to eq('New Name Configuration Manager')
expect(provider.provisioning_manager.name).to eq('New Name Provisioning Manager')
end
end
end

0 comments on commit 1fd7717

Please sign in to comment.