Skip to content
This repository has been archived by the owner on Nov 15, 2019. It is now read-only.

Adding status indication to entities on middleware topology #5

Open
miq-bot opened this issue Apr 9, 2017 · 11 comments
Open

Adding status indication to entities on middleware topology #5

miq-bot opened this issue Apr 9, 2017 · 11 comments

Comments

@miq-bot
Copy link
Member

miq-bot commented Apr 9, 2017

This is a placeholder to discuss what is the relevant field/work needed for each entity to have the status color indication to be displayed for each entity on the middleware topology.

@miq-bot add_label enhancement, providers/hawkular

Currently this is needed for:

  • provider - (the relevant check/method is the authentication status)
  • middleware_server
  • middleware_deployment
  • middleware_datasource
  • middleware_destination (jms topic/queue)

cc @pilhuhn please add your thoughts here


This issue was moved to this repository from ManageIQ/manageiq#9033, originally opened by @abonas

@israel-hdez
Copy link
Member

israel-hdez commented May 26, 2017

Right now, status is only resolved for servers and deployments.
I may work this in stages:

Regarding datasources and destinations/messagings I don't know if hawkular tracks their status in any metrics.

Also, with the ongoing discussion about making generic the Hawkular's UI part of MiQ, I'm not sure if I should work on this issue, because big changes may occur if that direction is taken.

cc @pilhuhn @abonas

@miq-bot
Copy link
Member Author

miq-bot commented May 26, 2017

@miq-bot Cannot apply the following label because they are not recognized: providers/hawkular

@miq-bot
Copy link
Member Author

miq-bot commented May 26, 2017

@miq-bot unrecognized command 'Cannot', ignoring...

Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

@israel-hdez
Copy link
Member

israel-hdez commented May 26, 2017

🔁 That bot is talking with itself... 😂

@miq-bot
Copy link
Member Author

miq-bot commented May 26, 2017

@miq-bot unrecognized command 'unrecognized', ignoring...

Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

@abonas
Copy link
Member

abonas commented May 28, 2017

@israel-hdez I think it's worth to add this for servers at this point. And then we'll see :)

@israel-hdez
Copy link
Member

Ok, I'm working on it.

israel-hdez added a commit to israel-hdez/manageiq-ui-classic that referenced this issue May 30, 2017
Status of middleware servers and deployments are set when building
topology view. This renders the status in tooltips in related
topology nodes and also renders status colors.

Regarding colors:
- For middleware servers, when status is:
  * Down => red
  * Running => green
  * Reload required => amber
  * Starting => amber
- For deployments:
  * Enabled => green
  * Disabled => amber

This is the first step to cover ManageIQ/manageiq-providers-hawkular#5
israel-hdez added a commit to israel-hdez/manageiq-ui-classic that referenced this issue May 30, 2017
Status of middleware servers and deployments are set when building
topology view. This renders the status in tooltips in related
topology nodes and also renders status colors.

Regarding colors:
- For middleware servers, when status is:
  * Down => red
  * Running => green
  * Reload required => amber
  * Starting => amber
- For deployments:
  * Enabled => green
  * Disabled => amber

This is the first step to cover ManageIQ/manageiq-providers-hawkular#5
@israel-hdez
Copy link
Member

israel-hdez commented May 31, 2017

Hmm... Looks like the better way to deal with the second task is to add a MetricsCollectorWorker and leave untouched the EventCatcher.

Although I am unsure about the name, because it won't collect metrics but, instead, just watch specific metrics related to the status change of server/deployments and update MiQ inventory data accordingly. Perhaps, should it be InventoryMonitorWorker?

For now I will stick with MetricsCollectorWorker because it looks like a standard name. Please comment if anybody believe I should use another name that is more descriptive about what the worker will be doing.

israel-hdez added a commit to israel-hdez/manageiq-ui-classic that referenced this issue Jun 6, 2017
Status of middleware servers and deployments are set when building
topology view. This renders the status in tooltips in related
topology nodes and also renders status colors.

Regarding colors:
- For middleware servers, when status is:
  * Down => red
  * Running => green
  * Reload required => amber
  * Starting => blue
- For deployments:
  * Enabled => green
  * Disabled => amber

This is the first step to cover ManageIQ/manageiq-providers-hawkular#5
@israel-hdez
Copy link
Member

Regarding the second step about adding a worker to monitor statuses, I read a little more about how is implemented an EventCatcher. Looks like the standard pattern is to enqueue catched events to be further processed in EmsEvent here, but the use case needed in this issue will be off that pattern supporting my idea that EventCatcher is not a good place to do status monitoring.

So, I tried to add a MetricsCollectorWorker but the standard pattern for it is to inherit from a base MetricsCollectorWorker which is a "queue". If I use this, the worker would just sit there waiting for something to come into the queue, which will never happen because there is nothing to feed that queue. So, I also don't see this as a viable option.

The last option I can think of is just to add a custom InventoryMonitorWorker inheriting from raw MiqWorker. Any advice against this? Or is there some other kind of standard worker that I could use for this?

cc @abonas

israel-hdez added a commit to israel-hdez/manageiq-ui-classic that referenced this issue Jun 7, 2017
Status of middleware servers and deployments are set when building
topology view. This renders the status in tooltips in related
topology nodes and also renders status colors.

Regarding colors:
- For middleware servers, when status is:
  * Down => red
  * Running => green
  * Reload required => amber
  * Starting => blue
- For deployments:
  * Enabled => green
  * Disabled => amber

This is the first step to cover ManageIQ/manageiq-providers-hawkular#5
@abonas
Copy link
Member

abonas commented Jun 8, 2017

Regarding the second step about adding a worker to monitor statuses, I read a little more about how is implemented an EventCatcher. Looks like the standard pattern is to enqueue catched events to be further processed in EmsEvent here, but the use case needed in this issue will be off that pattern supporting my idea that EventCatcher is not a good place to do status monitoring.

So, I tried to add a MetricsCollectorWorker but the standard pattern for it is to inherit from a base MetricsCollectorWorker which is a "queue". If I use this, the worker would just sit there waiting for something to come into the queue, which will never happen because there is nothing to feed that queue. So, I also don't see this as a viable option.

The last option I can think of is just to add a custom InventoryMonitorWorker inheriting from raw MiqWorker. Any advice against this? Or is there some other kind of standard worker that I could use for this?

cc @abonas

please check with miq core team

israel-hdez added a commit to israel-hdez/manageiq-ui-classic that referenced this issue Jun 12, 2017
Status of middleware servers and deployments are set when building
topology view. This renders the status in tooltips in related
topology nodes and also renders status colors.

Regarding colors:
- For middleware servers, when status is:
  * Down => red
  * Running => green
  * Reload required => amber
  * Starting => blue
- For deployments:
  * Enabled => green
  * Disabled => amber

This is the first step to cover ManageIQ/manageiq-providers-hawkular#5
israel-hdez added a commit to israel-hdez/manageiq-providers-hawkular that referenced this issue Jun 14, 2017
…ails

* Event catcher is extended to retrieve availability metrics from
  Hawkular for all deployments in inventory. Availabilities are "parsed"
  and compared against the status stored in MiQ database. Deployments
  whose status has changed are enqueued to be updated in the refresh
  worker.
* A targeted refresh is added. This targeted refresh only updates the
  status field of deployment entities when an availability update is
  received by the refresh worker. No other field is updated, nor entity
  creation or deletion is performed. That work is left to the full graph
  refresh.

These changes is work towards covering ManageIQ#5
josejulio pushed a commit to josejulio/manageiq-providers-hawkular that referenced this issue Dec 6, 2017
HAWKULAR-1275 Fix LiveMetricsCapture when provider is offline
@miq-bot
Copy link
Member Author

miq-bot commented Dec 25, 2017

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

@miq-bot miq-bot added the stale label Dec 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants