Skip to content
This repository has been archived by the owner on Nov 15, 2019. It is now read-only.

Add support to Datasource and Web Sessions conditions #68

Merged
merged 2 commits into from
Oct 6, 2017

Conversation

aljesusg
Copy link
Member

@aljesusg aljesusg commented Oct 5, 2017

@aljesusg
Copy link
Member Author

aljesusg commented Oct 5, 2017

@lucasponce What do you think about have the alerts of DataSource mw_ds_average_get_time, mw_ds_average_creation_time and mw_ds_max_wait_time like a Rate type instead threshold?

@aljesusg
Copy link
Member Author

aljesusg commented Oct 5, 2017

@miq-bot add_label wip

@lucasponce
Copy link
Contributor

@lucasponce What do you think about have the alerts of DataSource mw_ds_average_get_time, mw_ds_average_creation_time and mw_ds_max_wait_time like a Rate type instead threshold?

It might sense to use a rate or threshold, as behaviour are different in any case, I woud ask in the JIRA linnking the PM to confirm requeriment.

@miq-bot miq-bot added the wip label Oct 5, 2017
@aljesusg aljesusg force-pushed the metrics_alerts_datasource branch 2 times, most recently from f8a92e1 to 2e23963 Compare October 5, 2017 20:05
@aljesusg
Copy link
Member Author

aljesusg commented Oct 5, 2017

@miq-bot remove_label wip

@aljesusg aljesusg changed the title [WIP] Add support to Datasource conditions Add support to Datasource conditions Oct 5, 2017
@miq-bot miq-bot removed the wip label Oct 5, 2017
@miq-bot
Copy link
Member

miq-bot commented Oct 5, 2017

Checked commits aljesusg/manageiq-providers-hawkular@97094a5~...ffd21f1 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@aljesusg aljesusg changed the title Add support to Datasource conditions Add support to Datasource and Web Sessions conditions Oct 6, 2017
@aljesusg
Copy link
Member Author

aljesusg commented Oct 6, 2017

@lucasponce John told me in JIRA that we have to do with threshold. Can you review this PR? We need to request the merge in the UI ManageIQ/manageiq-ui-classic#2309

@aljesusg
Copy link
Member Author

aljesusg commented Oct 6, 2017

@miq-bot assign @abonas

@aljesusg
Copy link
Member Author

aljesusg commented Oct 6, 2017

@miq-bot add_label alerts, enhancement

@aljesusg
Copy link
Member Author

aljesusg commented Oct 6, 2017

@lucasponce ManageIQ/manageiq#16125 was merged, we need this to continue and for UI.

Copy link
Contributor

@lucasponce lucasponce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor PR, I see it correct, but I haven't tested locally.

@mtho11
Copy link
Contributor

mtho11 commented Oct 6, 2017

Thanks @lucasponce

Copy link
Member

@josejulio josejulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aljesusg
Copy link
Member Author

aljesusg commented Oct 6, 2017

Thanks @lucasponce & @josejulio

@mtho11
Copy link
Contributor

mtho11 commented Oct 6, 2017

Ok since @abonas is out, I'll self-assign and merge.

@mtho11 mtho11 self-assigned this Oct 6, 2017
@mtho11 mtho11 added this to the Sprint 71 Ending Oct 16, 2017 milestone Oct 6, 2017
@mtho11 mtho11 merged commit 2720b9e into ManageIQ:master Oct 6, 2017
@aljesusg
Copy link
Member Author

aljesusg commented Oct 6, 2017

Thanks @mtho11 for merge

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants