-
Notifications
You must be signed in to change notification settings - Fork 33
Add support to Datasource and Web Sessions conditions #68
Conversation
@lucasponce What do you think about have the alerts of DataSource mw_ds_average_get_time, mw_ds_average_creation_time and mw_ds_max_wait_time like a Rate type instead threshold? |
@miq-bot add_label wip |
It might sense to use a rate or threshold, as behaviour are different in any case, I woud ask in the JIRA linnking the PM to confirm requeriment. |
f8a92e1
to
2e23963
Compare
@miq-bot remove_label wip |
2e23963
to
ffd21f1
Compare
Checked commits aljesusg/manageiq-providers-hawkular@97094a5~...ffd21f1 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
@lucasponce John told me in JIRA that we have to do with threshold. Can you review this PR? We need to request the merge in the UI ManageIQ/manageiq-ui-classic#2309 |
@miq-bot add_label alerts, enhancement |
@lucasponce ManageIQ/manageiq#16125 was merged, we need this to continue and for UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor PR, I see it correct, but I haven't tested locally.
Thanks @lucasponce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @lucasponce & @josejulio |
Ok since @abonas is out, I'll self-assign and merge. |
Thanks @mtho11 for merge |
This is required by ManageIQ/manageiq#16125 and ManageIQ/manageiq#16113 to generate the conditions.
cc @josejulio
https://issues.jboss.org/browse/HAWKULAR-1255