New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shared memory pools as Resource Pools #115
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfebvre
requested review from
agrare,
Fryguy,
jaywcarman and
iv1111
as code owners
November 9, 2022 09:50
Signed-off-by: Vincent Febvre <vfebvre@us.ibm.com>
Signed-off-by: Vincent Febvre <vfebvre@us.ibm.com>
…nored usertask events Signed-off-by: Vincent Febvre <vfebvre@us.ibm.com>
…nored usertask events Signed-off-by: Vincent Febvre <vfebvre@us.ibm.com>
Signed-off-by: Vincent Febvre <vfebvre@us.ibm.com>
Signed-off-by: Vincent Febvre <vfebvre@us.ibm.com>
Signed-off-by: Vincent Febvre <vfebvre@us.ibm.com>
Signed-off-by: Vincent Febvre <vfebvre@us.ibm.com>
Looks good, @vfebvre I wonder if we should subclass Processor and Memory resource pools:
and pass that |
Signed-off-by: Vincent Febvre <vfebvre@us.ibm.com>
Checked commits vfebvre/manageiq-providers-ibm_power_hmc@0d85e12~...16ef89b with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
vfebvre
changed the title
[WIP] Add shared memory pools as Resource Pools
Add shared memory pools as Resource Pools
Nov 14, 2022
agrare
approved these changes
Nov 14, 2022
This was referenced Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding HMC Shared Memory Pools as ManageIQ Resource Pools, in addition to Shared Processor Pools (#100).
On the HMC, there can only be one Shared Memory Pool per Host.
Shared Memory Pools are not currently tied to VMs as ManageIQ VMs can only have one unique parent resource pool (and it is reserved for Processor Pools).