Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shared memory pools as Resource Pools #115

Merged
merged 10 commits into from Nov 14, 2022
Merged

Conversation

vfebvre
Copy link
Contributor

@vfebvre vfebvre commented Nov 9, 2022

Adding HMC Shared Memory Pools as ManageIQ Resource Pools, in addition to Shared Processor Pools (#100).

On the HMC, there can only be one Shared Memory Pool per Host.

Shared Memory Pools are not currently tied to VMs as ManageIQ VMs can only have one unique parent resource pool (and it is reserved for Processor Pools).

image

Vincent Febvre added 8 commits November 10, 2022 15:28
Signed-off-by: Vincent Febvre <vfebvre@us.ibm.com>
Signed-off-by: Vincent Febvre <vfebvre@us.ibm.com>
…nored usertask events

Signed-off-by: Vincent Febvre <vfebvre@us.ibm.com>
…nored usertask events

Signed-off-by: Vincent Febvre <vfebvre@us.ibm.com>
Signed-off-by: Vincent Febvre <vfebvre@us.ibm.com>
Signed-off-by: Vincent Febvre <vfebvre@us.ibm.com>
Signed-off-by: Vincent Febvre <vfebvre@us.ibm.com>
Signed-off-by: Vincent Febvre <vfebvre@us.ibm.com>
@agrare
Copy link
Member

agrare commented Nov 10, 2022

Looks good, @vfebvre I wonder if we should subclass Processor and Memory resource pools:

class ManageIQ::Providers::IbmPowerHmc::InfraManager::ProcessorResourcePool < ManageIQ::Providers::IbmPowerHmc::InfraManager::ResourcePool
end
class ManageIQ::Providers::IbmPowerHmc::InfraManager::MemoryResourcePool < ManageIQ::Providers::IbmPowerHmc::InfraManager::ResourcePool
end

and pass that :type => in when we parse them, just so we can easily tell the difference later on

Signed-off-by: Vincent Febvre <vfebvre@us.ibm.com>
@miq-bot
Copy link
Member

miq-bot commented Nov 14, 2022

Checked commits vfebvre/manageiq-providers-ibm_power_hmc@0d85e12~...16ef89b with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
10 files checked, 0 offenses detected
Everything looks fine. 👍

@vfebvre vfebvre changed the title [WIP] Add shared memory pools as Resource Pools Add shared memory pools as Resource Pools Nov 14, 2022
@miq-bot miq-bot removed the wip label Nov 14, 2022
@agrare agrare self-assigned this Nov 14, 2022
@agrare agrare added the enhancement New feature or request label Nov 14, 2022
@Fryguy Fryguy added this to Petrosian in Roadmap Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Roadmap
  
Petrosian
Development

Successfully merging this pull request may close these issues.

None yet

4 participants