Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collect media repositories as ISO storages #128

Merged
merged 7 commits into from Dec 20, 2022
Merged

collect media repositories as ISO storages #128

merged 7 commits into from Dec 20, 2022

Conversation

dberg1
Copy link
Contributor

@dberg1 dberg1 commented Dec 6, 2022 •
edited

With PowerVM, each VIOS can have a virtual media repository containing ISO images that can then be mapped to LPARs via VSCSI:

image

Depends on:

collect media repositories as ISO storages
38a7796 
Signed-off-by: Damien Bergamini <dbergami@us.ibm.com>
@miq-bot miq-bot added the wip label Dec 6, 2022
Damien Bergamini added 6 commits December 7, 2022 09:24
iso_images through media_repositories
e9b56a8 
Signed-off-by: Damien Bergamini <dbergami@us.ibm.com>
belongs_to already defined in parent class
18e8416 
Signed-off-by: Damien Bergamini <dbergami@us.ibm.com>
no need to redefine iso_images properties
724ce58 
Signed-off-by: Damien Bergamini <dbergami@us.ibm.com>
set store_type to SSP for shared storage pools
e350cfe 
Signed-off-by: Damien Bergamini <dbergami@us.ibm.com>
add spec for media repos
e4a8257 
Signed-off-by: Damien Bergamini <dbergami@us.ibm.com>
no need to specify store_type in find_by in spec
7ad5b27 
Signed-off-by: Damien Bergamini <dbergami@us.ibm.com>
@dberg1 dberg1 changed the title [WIP] collect media repositories as ISO storages collect media repositories as ISO storages Dec 20, 2022
@miq-bot miq-bot removed the wip label Dec 20, 2022
@miq-bot
Copy link
Member

miq-bot commented Dec 20, 2022

Checked commits https://github.com/dberg1/manageiq-providers-ibm_power_hmc/compare/38a77968a0b15d88532f4aab01b08fe8899cb457~...7ad5b2725ae7d9249b7beb79b3328426bb74cfd6 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
5 files checked, 0 offenses detected
Everything looks fine. ⭐

@agrare agrare self-assigned this Dec 20, 2022
@agrare agrare added the enhancement New feature or request label Dec 20, 2022
agrare
agrare approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@agrare agrare merged commit df5cbd5 into ManageIQ:master Dec 20, 2022
@dberg1 dberg1 deleted the mediarep branch December 21, 2022 08:08
@Fryguy Fryguy added this to the Petrosian milestone Sep 14, 2023
@Fryguy Fryguy added this to Petrosian in Roadmap Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

@Fryguy Fryguy Awaiting requested review from Fryguy Fryguy is a code owner

@jaywcarman jaywcarman Awaiting requested review from jaywcarman jaywcarman is a code owner

@iv1111 iv1111 Awaiting requested review from iv1111

Assignees

@agrare agrare

Labels
enhancement New feature or request
Projects
Roadmap
  
Petrosian
Milestone
Petrosian
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dberg1 @miq-bot @agrare @Fryguy