Update fog-kubevirt to newer version #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @agrare I think that further changes are required: The namespace was changed as well when we fog-kubevirt was bumped to support fog-code > 2.0 |
|
👍 thanks yeah just saw the test failures Trying to get on a newer version of kubeclient which is what prompted this |
agrare
force-pushed
the
bump_fog_kubevirt
branch
from
8ac8f8c
to
a343169
Compare
18 tasks
agrare
force-pushed
the
bump_fog_kubevirt
branch
from
a343169
to
7801837
Compare
|
Checked commit agrare@7801837 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint app/models/manageiq/providers/kubevirt/infra_manager/connection.rb
|
masayag
approved these changes
Apr 20, 2020
|
Thanks @masayag ! |
|
Backport depends on ManageIQ/manageiq-providers-kubernetes#368 |
simaishi
pushed a commit
that referenced
this pull request
Jun 10, 2020
Update fog-kubevirt to newer version (cherry picked from commit 91ae48c)
|
Jansa backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for the use of a newer version of kubeclient by bumping fog-kubevirt