Use vm status provided by kubevirt #82
Conversation
|
This PR fixes #69 |
|
This PR requires fog/fog-kubevirt#12 to work. |
| POWER_STATES = { | ||
| 'Running' => 'on', | ||
| 'Pending' => 'powering_up', | ||
| 'Scheduling' => 'powering_up', |
There was a problem hiding this comment.
@rmohr Please check whether I added here all the statuses that are possible for VMs. I based my list on pod life cycle https://blog.openshift.com/kubernetes-pods-life/
There was a problem hiding this comment.
Right now we have these: https://github.com/kubevirt/kubevirt/blob/master/pkg/api/v1/types.go#L303. The only one you are missing is Scheduled. That one does not exist on pods.
I also saw now that these fields are not reflected in the api-reference: http://www.kubevirt.io/api-reference/master/definitions.html#_v1_virtualmachinestatus. Will file an issue in kubevirt.
There was a problem hiding this comment.
And we should probably rethink our Scheduled and Pending and Scheduling meaning. We slightly diverge here from Pods, with out necessarily for a good reason. But for now it works like that.
There was a problem hiding this comment.
Great, I will update it with Scheduled. Feel free to open an issue if anything changes with vm statuses.
We assumed about vm status based on part of the flow we were in. This PR uses vm status as collected from kubevirt.
|
Checked commit pkliczewski@db2d4dc with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
We assumed about vm status based on part of the flow we were in.
This PR uses vm status as collected from kubevirt.