Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing log file before running tests #130

Merged

Conversation

tadeboro
Copy link
Contributor

Core repository no longer contains log folder, which needs to be
created manually.

This commit simply ensures that log folder is present when checking
out manageiq core repository into spec folder.

Core repository no longer contains log folder, which needs to be
created manually.

This commit simply ensures that log folder is present when checking
out manageiq core repository into spec folder.
@tadeboro
Copy link
Contributor Author

This intentionally only fixes problem with missing log folder. Other unrelated test failures are left intact.

@miq-bot
Copy link
Member

miq-bot commented Aug 21, 2018

Checked commit xlab-si@9b9a6ed with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@miha-plesko miha-plesko merged commit 52936b1 into ManageIQ:master Aug 21, 2018
@miha-plesko
Copy link
Contributor

Thanks @tadeboro , just for the record: this is the PR that drops log directory from git ManageIQ/manageiq#17663

@tadeboro tadeboro deleted the add-missing-spec-manageiq-log-dir branch August 21, 2018 08:21
@miha-plesko miha-plesko self-assigned this Aug 21, 2018
@miha-plesko miha-plesko added this to the Sprint 93 Ending Aug 27, 2018 milestone Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants