Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing refresher specs #19

Merged
merged 4 commits into from Jun 7, 2017
Merged

Conversation

cben
Copy link
Contributor

@cben cben commented Jun 5, 2017

Extracted from ManageIQ/manageiq#14337.
Addresses the test points from ManageIQ/manageiq-providers-kubernetes#27 that I could cover
without rerecording the main casette.
(I'll want to rerecord at some point but don't want to block on it now...)

  • SecurityContext is a Kubernetes concept, but we only have it in openshift casette, so tested here.

@zakiva @moolitayer Please review.
@miq-bot add-label test

@miq-bot
Copy link
Member

miq-bot commented Jun 5, 2017

Checked commits cben/manageiq-providers-openshift@f5711f5~...cfd5ffd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@cben
Copy link
Contributor Author

cben commented Jun 6, 2017

@zakiva @moolitayer @enoodle These are just specs, could someone review?

expect(@container_build_pod.container_group).to eq(
ContainerGroup.find_by(:name => "python-project-1-build")
)
expect(@container_build_pod.container_group.container_build_pod).to eq(@container_build_pod)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@moolitayer moolitayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@moolitayer moolitayer merged commit 10ff45a into ManageIQ:master Jun 7, 2017
@moolitayer moolitayer added this to the Sprint 63 Ending Jun 19, 2017 milestone Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants