New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some missing refresher specs #19
Conversation
Checked commits cben/manageiq-providers-openshift@f5711f5~...cfd5ffd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
@zakiva @moolitayer @enoodle These are just specs, could someone review? |
expect(@container_build_pod.container_group).to eq( | ||
ContainerGroup.find_by(:name => "python-project-1-build") | ||
) | ||
expect(@container_build_pod.container_group.container_build_pod).to eq(@container_build_pod) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Extracted from ManageIQ/manageiq#14337.
Addresses the test points from ManageIQ/manageiq-providers-kubernetes#27 that I could cover
without rerecording the main casette.
(I'll want to rerecord at some point but don't want to block on it now...)
@zakiva @moolitayer Please review.
@miq-bot add-label test