Catch Bad Request responses in safe_call

[mansam]

Should fix https://bugzilla.redhat.com/show_bug.cgi?id=1611848

[miq-bot]

Checked commit mansam@a92e279 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 2 offenses detected

app/models/manageiq/providers/openstack/refresh_parser_common/helper_methods.rb

• ❗ - Line 70, Col 11 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.
• ❗ - Line 71, Col 11 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.

[aufi]

Makes sense to me given other types or error handled is the same way.

Merging!

[JPrause]

@miq-bot add_label blocker

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 4894d7dae1e01a61ce0ec644195a858148352b2f
Author: Marek Aufart <aufi.cz@gmail.com>
Date:   Tue Aug 7 14:46:14 2018 +0200

    Merge pull request #330 from mansam/catch-bad-requests-during-refresh
    
    Catch Bad Request responses in safe_call
    (cherry picked from commit 9bc4293ee16e8977450b3002f5fd383129e3f1cc)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1613757

[simaishi]

Fine backport (to manageiq repo) details:

$ git log -1
commit 73ec980f1532d0d877e7524a0c9b9d9cffc75c22
Author: Marek Aufart <aufi.cz@gmail.com>
Date:   Tue Aug 7 14:46:14 2018 +0200

    Merge pull request #330 from mansam/catch-bad-requests-during-refresh
    
    Catch Bad Request responses in safe_call
    (cherry picked from commit 9bc4293ee16e8977450b3002f5fd383129e3f1cc)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1613758