Fix targeted refresh for nested stacks and their resource relations #534
Conversation
So the all of the vms get refreshed, even if the list of vms is expanded by scanning stacks.
First the stack target was not extracted from the event, because it goes as resource_id, not stack_id. Second we need to always add all parent stacks as targets (so the chain of relations gets connected) and we need to scan resources to connect all instances to the stack. (Issue found and fixed as part of hackaton) Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1732861
| end | ||
|
|
||
| def get_orchestration_stack(stack_id, _tenant_id = nil) | ||
| # TODO fog needs to implement /v1/{tenant_id}/stacks/{stack_identity} call, right now the only supported call |
There was a problem hiding this comment.
didn't @aufi send PR for this to fog-openstack? Or do I mistake it for something else?
andyvesel
force-pushed
the
fix_targeted_refresh_for_nested_stacks_and_their_resource_relations
branch
from
1e04e25
to
25a14c8
Compare
andyvesel
requested review from
agrare,
aufi,
Fryguy and
mansam
as code owners
andyvesel
force-pushed
the
fix_targeted_refresh_for_nested_stacks_and_their_resource_relations
branch
from
25a14c8
to
b2ecf59
Compare
|
Checked commits andyvesel/manageiq-providers-openstack@fcedec5~...b2ecf59 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
LGTM based on previous comments, merging! |
andyvesel
deleted the
fix_targeted_refresh_for_nested_stacks_and_their_resource_relations
branch
|
@andyvesel @aufi All spec files (vcr cassettes) conflict backporting to |
|
@simaishi sure, will do |
|
@andyvesel ping |
|
@andyvesel same thing on ivanchuk branch. Please create a separate PR. If hammer/ivanchuk PRs will be identical, please just create a PR against ivanchuk and mark the PR as |
|
@andyvesel @aufi ping |
|
@simaishi Hi, yes, I'm going to prepare backport PRs (today). |
|
Having issues with infrastructure which postpones VCRs recording. |
|
Backported to hammer via #550 |
|
Backported to ivanchuk via #551 |
Authored by @Ladas from #487
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1728624
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1732861