Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix partial refresh with new host #19

Merged
merged 1 commit into from Apr 25, 2017
Merged

Fix partial refresh with new host #19

merged 1 commit into from Apr 25, 2017

Conversation

borod108
Copy link
Contributor

There was a mistake in the signature of the partial_host_hash method in the v4 parser.

Fix partial refresh with new host
4c0d227 
There was a mistake in the signature of the partial_host_hash method in the v4 parser.
@borod108
Copy link
Contributor Author

@masayag, @pkliczewski can one of you please review?

@miq-bot
Copy link
Member

miq-bot commented Apr 25, 2017

Checked commit borod108@4c0d227 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🍰

@borod108
Copy link
Contributor Author

@durandom this is a bug that slipped in can we merge it in now?

@durandom durandom merged commit d00a965 into ManageIQ:master Apr 25, 2017
@durandom durandom added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 25, 2017
@simaishi
Copy link
Contributor

Fine backport (to manageiq repo) details:

$ git log -1
commit 448a1a342162d8a3fc7be8db19a218b070e7e656
Author: Marcel Hild <hild@b4mad.net>
Date:   Tue Apr 25 15:26:03 2017 +0200

    Merge pull request #19 from borod108/bugs/partial_host_hash
    
    Fix partial refresh with new host
    (cherry picked from commit d00a965e4a9446f6eebd98298a2aaf67e9506c0c)

@borod108 borod108 deleted the bugs/partial_host_hash branch December 4, 2018 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkliczewski pkliczewski pkliczewski approved these changes

Assignees
No one assigned
Labels
bug fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@borod108 @miq-bot @simaishi @pkliczewski @durandom