Fix rescue during PXE and ISO provisioning #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add-label wip |
borod108
changed the title
borod108
force-pushed
the
bugs/1446409pxe_prov
branch
from
bb9ea81
to
b285153
Compare
borod108
changed the title
|
@borod108 Cannot apply the following label because they are not recognized: bug/blocker |
|
@miq-bot add-label wip |
miq-bot
changed the title
borod108
force-pushed
the
bugs/1446409pxe_prov
branch
from
b285153
to
f57fa3b
Compare
masayag
approved these changes
May 1, 2017
|
@miq-bot remove-label wip |
miq-bot
changed the title
|
@durandom hi this is a blocker, please take a look. |
|
This looks like something that could use a test. |
|
@borod108 do you want to add a short test for |
borod108
force-pushed
the
bugs/1446409pxe_prov
branch
from
f57fa3b
to
51d25d6
Compare
|
@durandom added a spec that would have caught the bug, as for the the method in ovirt_services, I am working on getting as much coverage there as possible but it will take some time. |
borod108
force-pushed
the
bugs/1446409pxe_prov
branch
from
51d25d6
to
911f6df
Compare
|
Checked commit borod108@911f6df with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
durandom
approved these changes
May 2, 2017
|
Fine backport (to manageiq repo) details: |
agrare
pushed a commit
to agrare/manageiq-providers-ovirt
that referenced
this pull request
May 16, 2017
Add a Gitter chat badge to README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1446409