Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging oVirt event in debug level #255

Merged
merged 1 commit into from May 31, 2018
Merged

Fix logging oVirt event in debug level #255

merged 1 commit into from May 31, 2018

Conversation

borod108
Copy link
Contributor

The log would fail on new events when set to debug level.
As a result refresh would not run and provider not updated.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1580521

Fix logging oVirt event in debug level
2f46b52 
The log would fail on new events when set to debug level.
As a result refresh would not run and provider not updated.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1580521
@miq-bot
Copy link
Member

miq-bot commented May 31, 2018

Checked commit borod108@2f46b52 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@simaishi simaishi mentioned this pull request May 31, 2018
Closed
@agrare agrare self-assigned this May 31, 2018
@agrare agrare merged commit 2f46b52 into ManageIQ:master May 31, 2018
agrare added a commit that referenced this pull request May 31, 2018
@agrare
Merge pull request #255 from borod108/bugs/1580521logging_even_master
d0c12af 
Fix logging oVirt event in debug level
@agrare agrare added this to the Sprint 87 Ending Jun 4, 2018 milestone May 31, 2018
simaishi pushed a commit that referenced this pull request May 31, 2018
@agrare @simaishi
Merge pull request #255 from borod108/bugs/1580521logging_even_master
af00b74 
Fix logging oVirt event in debug level
(cherry picked from commit d0c12af)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1584687
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit af00b74ecc08173da6dbc9bb914a158eddc61cb1
Author: Adam Grare <agrare@redhat.com>
Date:   Thu May 31 08:22:29 2018 -0400

    Merge pull request #255 from borod108/bugs/1580521logging_even_master
    
    Fix logging oVirt event in debug level
    (cherry picked from commit d0c12af900aba0c1cd5b8561cf7940f803bfd6aa)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1584687

@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 6bfd21cfd1c9cab2fea06f8d696362f6f139c1b3
Author: Adam Grare <agrare@redhat.com>
Date:   Thu May 31 08:22:29 2018 -0400

    Merge pull request #255 from borod108/bugs/1580521logging_even_master
    
    Fix logging oVirt event in debug level
    (cherry picked from commit d0c12af900aba0c1cd5b8561cf7940f803bfd6aa)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1584688

@borod108 borod108 deleted the bugs/1580521logging_even_master branch December 4, 2018 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

Assignees

@agrare agrare

Labels
blocker bug fine/backported gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@borod108 @miq-bot @simaishi @agrare