Fix provisioning independent VM #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masayag
approved these changes
Aug 20, 2018
pkliczewski
approved these changes
Aug 20, 2018
borod108
force-pushed
the
bugs/1598747provisioning_clone
branch
from
87b0ab4
to
53d3308
Compare
|
@agrare Hi, do you have any idea why the ci is failing? |
|
@borod108 please add doc_text to the bug explaining the semantics of the flow. |
|
@masayag thank you, done. |
|
LGTM, so it can be included in 5.10 build |
borod108
force-pushed
the
bugs/1598747provisioning_clone
branch
from
53d3308
to
cc01e4b
Compare
We ignored the clone_type parameter during provisioning from template. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1598747
borod108
force-pushed
the
bugs/1598747provisioning_clone
branch
from
cc01e4b
to
8dd133f
Compare
|
@masayag @pkliczewski can you please review again? I added a change to respect the linked_clone parameter if it is supplied. |
|
Checked commit borod108@8dd133f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Aug 31, 2018
Fix provisioning independent VM (cherry picked from commit b88ddd1) https://bugzilla.redhat.com/show_bug.cgi?id=1621449
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ignored the clone_type parameter during provisioning from template.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1598747