Use the host_geust_devices inventory collection

[agrare]

Prevent duplication of host guest_devices by using the correct
association.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1691109

[miq-bot]

Checked commit agrare@d4f2903 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

[borod108]

Cool! How would you say we should test this?
(We can do it in a separate PR thought)

[agrare]

@borod108 what we should do is update all the refresh specs to do 2.times {} around the refresh and expect blocks (e.g. https://github.com/ManageIQ/manageiq-providers-vmware/blob/master/spec/models/manageiq/providers/vmware/infra_manager/inventory/collector_spec.rb#L22-L37).

This catches any issues like this where two refreshes run back to back don't yield the same result.

I tried doing this but was getting vcr errors:

bundle exec rspec spec/models/manageiq/providers/redhat/infra_manager/refresh//refresher_4_async_graph_spec.rb
  1) ManageIQ::Providers::Redhat::InfraManager::Refresh::Refresher will perform a full refresh on v4.1
     Failure/Error: raise "connection_vcr could not find a response for: #{req_key}"
     
     RuntimeError:
       connection_vcr could not find a response for: https://localhost:8443/ovirt-engine/api/clusters{}GET
     # ./spec/support/ovirt_sdk/connection_vcr.rb:32:in `wait'
     # /var/lib/gems/2.5.0/gems/ovirt-engine-sdk-4.2.5/lib/ovirtsdk4/service.rb:44:in `wait'

cc @slemrmartin

[agrare]

I tested this against a live RHV system by doing:

EmsRefresh.refresh(ManageIQ::Providers::Redhat::InfraManager.first)
GuestDevice.count

Twice

[agrare]

@simaishi before you backport this we'll need ManageIQ/manageiq@b528ade1615 which adds the host_guest_devices inventory collection

[simaishi]

Hammer backport details:

$ git log -1
commit 38522a8832afa14e218472b140caca0b54e36ff1
Author: Boris Od <bodnopoz@redhat.com>
Date:   Thu Apr 25 18:48:40 2019 +0300

    Merge pull request #360 from agrare/bz_1691109_use_host_guest_device_association
    
    Use the host_geust_devices inventory collection
    
    (cherry picked from commit 49ac6425ecbcc868d6676a0a9d534120b6de73f0)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1731237

[simaishi]

@agrare thank you for the note, confirmed host_guest_devices is in hammer branch.