This repository has been archived by the owner on Jul 25, 2023. It is now read-only.
Add verify_credentials and params_for_create #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 tasks
agrare
force-pushed
the
add_verify_credentials
branch
from
9dbbf27
to
49ece2b
Compare
Add a method to return the parameters required to add an SCVMM provider and a method to verity credentials with those parameters.
agrare
force-pushed
the
add_verify_credentials
branch
from
49ece2b
to
648b60d
Compare
|
Checked commit agrare@648b60d with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Fryguy
reviewed
Oct 1, 2019
| @@ -20,6 +20,61 @@ def self.description | |||
| @description ||= "Microsoft System Center VMM".freeze | |||
| end | |||
|
|
|||
| def self.params_for_create | |||
| @params_for_create ||= { | |||
There was a problem hiding this comment.
No constant like the other providers?
There was a problem hiding this comment.
I thought a constant plus a class method could be confusing, didn't want people to use the constant instead. Plus the rest of this class uses the @ ||= style to prevent allocating these on every method call
There was a problem hiding this comment.
Ok...I'd almost rather we change the other ones with constants to be consistent, then.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a method to return the parameters required to add an SCVMM provider
and a method to verity credentials with those parameters.
ManageIQ/manageiq#18818