Fix vmware spec tests #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durandom
suggested changes
Jan 18, 2017
| @@ -1,4 +1,4 @@ | |||
| require Rails.root.join('spec/tools/vim_data/vim_data_test_helper') | |||
| require File.join(ManageIQ::Providers::Vmware::Engine.root, 'spec/tools/vim_data/vim_data_test_helper.rb') | |||
There was a problem hiding this comment.
You can also
require ManageIQ::Providers::Vmware::Engine.root.join('spec/tools/vim_data/vim_data_test_helper.rb').to_sor, what I do in aws, require_relative and keep the file close to where it's actually used.
Like vim_data_test_helper seems to be only used by specs in vmware/infra_manager - why not put it here?
There was a problem hiding this comment.
Yeah I like the idea of moving it, will push a commit for that shortly
| @@ -3,10 +3,9 @@ | |||
| SimpleCov.start | |||
| end | |||
|
|
|||
| # Uncomment in case you use vcr cassettes | |||
agrare
force-pushed
the
fix_vmware_spec_tests
branch
from
9c12213
to
9ce2bff
Compare
Ah how did that sneak in :( good 👀 fixed |
|
Okay moved |
agrare
force-pushed
the
fix_vmware_spec_tests
branch
from
4a66ce3
to
5e9cade
Compare
|
Moving the This gets the tests green, @Fryguy @blomquisg merge? |
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Apr 15, 2019
Add services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed the big comment that said
# Uncomment in case you use vcr cassettesand requires withRails.rootare no longer working so use theEngine.root