Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse VM firmware_type (BIOS/EFI) #459

Merged
merged 1 commit into from Oct 7, 2019

Conversation

agrare
Copy link
Member

@agrare agrare commented Oct 4, 2019

Collect and parse if a VM has BIOS or EFI firmware type.

Depends: ManageIQ/vmware_web_service#65

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1798083

Collect and parse if a VM has BIOS or EFI firmware type.
@miq-bot
Copy link
Member

miq-bot commented Oct 4, 2019

Checked commit agrare@b90efe0 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
5 files checked, 0 offenses detected
Everything looks fine. ⭐

@agrare agrare closed this Oct 4, 2019
@agrare agrare reopened this Oct 4, 2019
@gtanzillo gtanzillo added this to the Sprint 122 Ending Oct 14, 2019 milestone Oct 7, 2019
@gtanzillo gtanzillo merged commit c27abb6 into ManageIQ:master Oct 7, 2019
@agrare agrare deleted the parse_vm_firmware_type branch October 7, 2019 13:10
@simaishi
Copy link
Contributor

@agrare Looks like we need to bump vmware_web_service version in ivanchuk for this. Can you create a PR to bump?

@agrare
Copy link
Member Author

agrare commented Feb 21, 2020

@simaishi #535

agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Feb 21, 2020
Parse VM firmware_type (BIOS/EFI)

(cherry picked from commit c27abb6)
agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Feb 22, 2020
Parse VM firmware_type (BIOS/EFI)

(cherry picked from commit c27abb6)
agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Feb 24, 2020
Parse VM firmware_type (BIOS/EFI)

(cherry picked from commit c27abb6)
@simaishi
Copy link
Contributor

Backported to ivanchuk via #536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants