New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse VM firmware_type (BIOS/EFI) #459
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collect and parse if a VM has BIOS or EFI firmware type.
Checked commit agrare@b90efe0 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Fryguy
approved these changes
Oct 4, 2019
@agrare Looks like we need to bump vmware_web_service version in ivanchuk for this. Can you create a PR to bump? |
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Feb 21, 2020
Parse VM firmware_type (BIOS/EFI) (cherry picked from commit c27abb6)
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Feb 22, 2020
Parse VM firmware_type (BIOS/EFI) (cherry picked from commit c27abb6)
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Feb 24, 2020
Parse VM firmware_type (BIOS/EFI) (cherry picked from commit c27abb6)
Backported to ivanchuk via #536 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collect and parse if a VM has BIOS or EFI firmware type.
Depends: ManageIQ/vmware_web_service#65
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1798083