Allow specifying the datastore/network for OVF deployment. #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfu
changed the title
agrare
reviewed
Nov 18, 2020
| @@ -28,6 +28,7 @@ def deployment_spec(opts) | |||
|
|
|||
| spec = {"accept_all_EULA" => opts[:accept_all_eula]} | |||
| spec["name"] = opts[:vm_name] if opts[:vm_name].present? | |||
| spec["default_datastore_id"] = Storage.find_by(:id => opts[:storage_id]).ems_ref if opts[:storage_id].present? | |||
There was a problem hiding this comment.
Should we be setting an ems_ref to an _id property? Also if the find_by returns nil .ems_ref is going to blow up, recommend .find_by()&.ems_ref
There was a problem hiding this comment.
default_datastore_id is the name that VMware uses. MIQ saves it as ems_ref for a storage.
agrare
reviewed
Nov 18, 2020
| @@ -45,7 +46,8 @@ | |||
| :accept_all_eula => true, | |||
| :resource_pool_id => "2", | |||
| :ems_folder_id => "3", | |||
| :host_id => "1" | |||
| :host_id => "1", | |||
| :storage_id => "1" | |||
lfu
force-pushed
the
ovf_storage_i_15722
branch
2 times, most recently
from
7a20f77
to
5532656
Compare
agrare
approved these changes
Nov 19, 2020
lfu
force-pushed
the
ovf_storage_i_15722
branch
2 times, most recently
from
6dc9cef
to
a32137f
Compare
lfu
changed the title
lfu
force-pushed
the
ovf_storage_i_15722
branch
from
a32137f
to
cc74215
Compare
lfu
force-pushed
the
ovf_storage_i_15722
branch
from
cc74215
to
d06dab3
Compare
|
Checked commit lfu@d06dab3 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
|
@agrare @gtanzillo Please take a final review. |
gtanzillo
approved these changes
Nov 20, 2020
Fryguy
pushed a commit
that referenced
this pull request
Nov 30, 2020
Allow specifying the datastore/network for OVF deployment. (cherry picked from commit 6fb67cd)
|
Kasparov backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the user to specify the datastore/network for the OVF deployment when creating the service template or through the service dialog.
Depends on ManageIQ/manageiq-ui-classic#7521.
Depends on #671.
@miq-bot add_label enhancement