Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specs showing ems_custom_attribute bug #771

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Add specs showing ems_custom_attribute bug #771

merged 1 commit into from
Dec 20, 2021

Conversation

agrare
Copy link
Member

@agrare agrare commented Dec 16, 2021

No description provided.

@agrare agrare requested a review from Fryguy as a code owner December 16, 2021 19:46
@agrare agrare mentioned this pull request Dec 16, 2021
Merged
@miq-bot
Copy link
Member

miq-bot commented Dec 16, 2021

Checked commit agrare@62d213c with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 👍

@Fryguy Fryguy closed this Dec 16, 2021
@Fryguy Fryguy reopened this Dec 16, 2021
@agrare
Copy link
Member Author

agrare commented Dec 16, 2021

Thanks @Fryguy , this is green

@Fryguy Fryguy merged commit f03d833 into ManageIQ:master Dec 20, 2021
@Fryguy Fryguy self-assigned this Dec 20, 2021
@agrare agrare deleted the add_specs_ems_custom_attribute_bug branch December 20, 2021 21:12
@Fryguy
Copy link
Member

Fryguy commented Jan 10, 2022

Backported to morphy in commit 542e2f0.

commit 542e2f08931e97aa09444f4925d8f2111ff68320
Author: Jason Frey <fryguy9@gmail.com>
Date:   Mon Dec 20 16:02:04 2021 -0500

    Merge pull request #771 from agrare/add_specs_ems_custom_attribute_bug
    
    Add specs showing ems_custom_attribute bug
    
    (cherry picked from commit f03d8337d1e1a186e64df81ff52cc3523b2b3b7f)

Fryguy added a commit that referenced this pull request Jan 10, 2022
@Fryguy
Merge pull request #771 from agrare/add_specs_ems_custom_attribute_bug
542e2f0 
Add specs showing ems_custom_attribute bug

(cherry picked from commit f03d833)
@Fryguy
Copy link
Member

Fryguy commented Jan 10, 2022

Backported to lasker in commit 7be3eac.

commit 7be3eac681f54fbb454ef05c104844eb93ce2422
Author: Jason Frey <fryguy9@gmail.com>
Date:   Mon Dec 20 16:02:04 2021 -0500

    Merge pull request #771 from agrare/add_specs_ems_custom_attribute_bug
    
    Add specs showing ems_custom_attribute bug
    
    (cherry picked from commit f03d8337d1e1a186e64df81ff52cc3523b2b3b7f)

Fryguy added a commit that referenced this pull request Jan 10, 2022
@Fryguy
Merge pull request #771 from agrare/add_specs_ems_custom_attribute_bug
7be3eac 
Add specs showing ems_custom_attribute bug

(cherry picked from commit f03d833)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fryguy Fryguy Awaiting requested review from Fryguy Fryguy is a code owner

Assignees

@Fryguy Fryguy

Labels
bug lasker/backported morphy/backported test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@agrare @miq-bot @Fryguy