Ensure Remote Console tickets aren't VimStrings

[agrare]

When openings a VMRC Console a MiqTask is created and vm.remote_console_vmrc_acquire_ticket is called on the queue.
The ticket string returned by vim.acquireCloneTicket is a VimString type. This then is saved in the task_results which throws an exception when loaded due to VMwareWebService/VimTypes not being loaded in the webserver.

=> #<MiqTask id: 78, name: "acquiring Vm ag_/test_\\ren%amed VMRC remote consol...", state: "Finished", status: "Ok", message: "Task completed successfully", userid: "admin", created_on: "2022-01-14 15:25:10", updated_on: "2022-01-14 15:25:10", pct_complete: nil, context_data: nil, results: nil, miq_server_id: 1, identifier: nil, started_on: "2022-01-14 15:25:10", zone: nil>
>> vmrc_task.task_results
   (0.5ms)  SELECT "binary_blob_parts"."data" FROM "binary_blob_parts" WHERE "binary_blob_parts"."binary_blob_id" = $1 ORDER BY "binary_blob_parts"."id" ASC  [["binary_blob_id", 55]]
=> {:ticket=>"cst-VCT-5202d576-98d3-d347-39b5-eb798442a3dd--tp-85-88-00-9D-4C-D2-52-9B-10-B1-33-00-40-56-DA-6D-06-F5-C9-87", :remote_url=>"vmrc://clone:cst-VCT-5202d576-98d3-d347-39b5-eb798442a3dd--tp-85-88-00-9D-4C-D2-52-9B-10-B1-33-00-40-56-DA-6D-06-F5-C9-87@icovcpc65.rtp.raleigh.ibm.com:443/?moid=vm-53550", :proto=>"remote"}
>> vmrc_task.task_results[:ticket].class
   (0.4ms)  SELECT "binary_blob_parts"."data" FROM "binary_blob_parts" WHERE "binary_blob_parts"."binary_blob_id" = $1 ORDER BY "binary_blob_parts"."id" ASC  [["binary_blob_id", 55]]
=> VimString

The raw data looks like:

>> BinaryBlob.find(55).binary_blob_parts.first.data
  BinaryBlob Load (0.6ms)  SELECT "binary_blobs".* FROM "binary_blobs" WHERE "binary_blobs"."id" = $1 LIMIT $2  [["id", 55], ["LIMIT", 1]]
  BinaryBlob Inst Including Associations (0.1ms - 1rows)
  BinaryBlobPart Load (0.4ms)  SELECT "binary_blob_parts".* FROM "binary_blob_parts" WHERE "binary_blob_parts"."binary_blob_id" = $1 ORDER BY "binary_blob_parts"."id" ASC LIMIT $2  [["binary_blob_id", 55], ["LIMIT", 1]]
  BinaryBlobPart Inst Including Associations (0.1ms - 1rows)
=> "---\n:ticket: !ruby/string:VimString\n  str: cst-TICKET\n  xsiType: :SOAP::SOAPString\n  vimType:\n:remote_url: vmrc://clone:cst-TICKET@vcenter.local:443/?moid=vm-53550\n:proto: remote\n"

Data migration: ManageIQ/manageiq-schema#631
Fixes #778

[agrare]

Working on a schema migration for this but binary_blob_parts#data is a binary not a string so my usual REGEXP_REPLACE is failing

[Fryguy]

Can you add a spec for this or is it too complicated?

[Fryguy]

Strange that travis didn't run on this PR.

[agrare]

Can you add a spec for this or is it too complicated?

👍 yeah should be able to

[agrare]

Oh yeah you're right

[Fryguy]

Slightly clearer

Suggested change

	expect(ticket[:ticket].class.name).to eq("String") # Ensure that VimStrings aren't returned
	expect(ticket[:ticket]).to be_instance_of(String) # Ensure that VimStrings aren't returned

Can't use be_a or be_kind_of because that would account for subclassing, but I believe be_instance_of ignores subclassing

[agrare]

Ah didn't do that because I thought VimString (subclass of String) might return true but looks like that isn't the case

[Fryguy]

Backported to morphy in commit af3e8ad.

commit af3e8adb2e35f1533edac84b32bffc7e3b0b33e0
Author: Jason Frey <fryguy9@gmail.com>
Date:   Fri Jan 14 16:15:25 2022 -0500

    Merge pull request #779 from agrare/remote_console_ticket_vim_string
    
    Ensure Remote Console tickets aren't VimStrings
    
    (cherry picked from commit c031f88b918eb1b8b35ebb3d8df1e233471c6140)

[Fryguy]

Backported to lasker in commit 6f0aaa5.

commit 6f0aaa59492646dbc1b04e95e17dfa4ed87ec416
Author: Jason Frey <fryguy9@gmail.com>
Date:   Fri Jan 14 16:15:25 2022 -0500

    Merge pull request #779 from agrare/remote_console_ticket_vim_string
    
    Ensure Remote Console tickets aren't VimStrings
    
    (cherry picked from commit c031f88b918eb1b8b35ebb3d8df1e233471c6140)