[LASKER] Delay WaitForUpdates #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delay WaitForUpdates and save in one thread to prevent "update storm" causing saver thread to be backed up (cherry picked from commit a37bc28)
agrare
force-pushed
the
lasker_add_threaded_saver_setting
branch
from
d019fef
to
dbf88a2
Compare
|
Ok, I ran the script to backport 754 and 753 so it would take care of all the labeling...surprised this conflicted, but it should be good it you rebase and the first 2 commits should go away |
|
Checked commit agrare@dbf88a2 with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint |
|
Yeah I was surprised it conflicted also since there were no other commits missing from master 🤷 was just this one line https://github.com/ManageIQ/manageiq-providers-vmware/pull/787/files#diff-c3abdb8e922b3a9bbdf85dab00139f5bc1ca94e548558b488b2f5e7e24be790eL19-R19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.