Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If there is no vnicDev passed in don't call edit_vlan_device #96

Merged
merged 1 commit into from Aug 11, 2017
Merged

If there is no vnicDev passed in don't call edit_vlan_device #96

merged 1 commit into from Aug 11, 2017

Conversation

agrare
Copy link
Member

@agrare agrare commented Aug 11, 2017 •
edited

If there is no vnicDev passed in to build_config_spec_vlan or build_config_spec_dvs then don't call edit_vlan_device

ERROR -- : Q-task_id([miq_provision_1000000001101]) MIQ(ManageIQ::Providers::Vmware::InfraManager::Provision#provision_error) [[NoMethodError]: undefined method `xsiType' for nil:NilClass] encountered during phase [start_clone_task]
ERROR -- : Q-task_id([miq_provision_1000000001101]) /opt/rh/cfme-gemset/bundler/gems/manageiq-providers-vmware-a1dd5cad9e94/app/models/manageiq/providers/vmware/infra_manager/provision/configuration/network.rb:122:in `edit_vlan_device'
/opt/rh/cfme-gemset/bundler/gems/manageiq-providers-vmware-a1dd5cad9e94/app/models/manageiq/providers/vmware/infra_manager/provision/configuration/network.rb:53:in `block in build_config_spec_vlan'

https://bugzilla.redhat.com/show_bug.cgi?id=1477256

@agrare agrare added the bug label Aug 11, 2017
@miq-bot
Copy link
Member

miq-bot commented Aug 11, 2017

Checked commit agrare@7f988f1 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@agrare agrare requested a review from gmcculloug August 11, 2017 15:54
gmcculloug
gmcculloug approved these changes Aug 11, 2017
View reviewed changes
Copy link
Member

@gmcculloug gmcculloug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gmcculloug gmcculloug merged commit 0bab376 into ManageIQ:master Aug 11, 2017
@gmcculloug gmcculloug added this to the Sprint 67 Ending Aug 21, 2017 milestone Aug 11, 2017
@agrare agrare deleted the bz_1477256_error_trying_to_edit_nil_vnic branch August 11, 2017 16:21
simaishi pushed a commit that referenced this pull request Aug 14, 2017
@gmcculloug @simaishi
Merge pull request #96 from agrare/bz_1477256_error_trying_to_edit_ni…
cee8faf 
…l_vnic

If there is no vnicDev passed in don't call edit_vlan_device
(cherry picked from commit 0bab376)

https://bugzilla.redhat.com/show_bug.cgi?id=1481450
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit cee8faf8cce2b313940d1fe97c47038d17887ae1
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Fri Aug 11 12:14:31 2017 -0400

    Merge pull request #96 from agrare/bz_1477256_error_trying_to_edit_nil_vnic
    
    If there is no vnicDev passed in don't call edit_vlan_device
    (cherry picked from commit 0bab3765ff3943ddd7f62918c19a36258a495244)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1481450

@simaishi
Copy link
Contributor

Euwe backport (to manageiq repo) details:

$ git log -1
commit a3be21c222e2894970691f58d27c23101f3fba0b
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Fri Aug 11 12:14:31 2017 -0400

    Merge pull request #96 from agrare/bz_1477256_error_trying_to_edit_nil_vnic
    
    If there is no vnicDev passed in don't call edit_vlan_device
    (cherry picked from commit 0bab3765ff3943ddd7f62918c19a36258a495244)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1481867

agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Apr 15, 2019
@gmcculloug
Merge pull request ManageIQ#96 from mfeifer/finechangelog
ec4057c 
Changelog Fine Beta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmcculloug gmcculloug gmcculloug approved these changes

Assignees

@gmcculloug gmcculloug

Labels
bug euwe/backported fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@agrare @miq-bot @simaishi @gmcculloug