New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tools for building hotfix RPMs #390
Conversation
da5a799
to
0ca6832
Compare
def generate_rpm | ||
where_am_i | ||
|
||
FileUtils.mkdir_p(BUILD_DIR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be:
FileUtils.mkdir_p(BUILD_DIR) | |
FileUtils.mkdir_p(HOTFIX_DIR) |
If not, and it's assumed HOTFIX_DIR will exist, then I don't know why you'd need the mkdir_p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
Checked commit bdunne@6c384e8 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint lib/manageiq/rpm_build/build_hotfix.rb
|
Backported to
|
Add tools for building hotfix RPMs (cherry picked from commit 742284b)
No description provided.