Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tools for building hotfix RPMs #390

Merged
merged 1 commit into from May 9, 2023
Merged

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented May 8, 2023

No description provided.

@bdunne bdunne added enhancement New feature or request petrosian/yes? labels May 8, 2023
@bdunne bdunne force-pushed the hotfix_build branch 5 times, most recently from da5a799 to 0ca6832 Compare May 9, 2023 14:20
def generate_rpm
where_am_i

FileUtils.mkdir_p(BUILD_DIR)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be:

Suggested change
FileUtils.mkdir_p(BUILD_DIR)
FileUtils.mkdir_p(HOTFIX_DIR)

If not, and it's assumed HOTFIX_DIR will exist, then I don't know why you'd need the mkdir_p

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@miq-bot
Copy link
Member

miq-bot commented May 9, 2023

Checked commit bdunne@6c384e8 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
3 files checked, 5 offenses detected

lib/manageiq/rpm_build/build_hotfix.rb

@Fryguy Fryguy merged commit 742284b into ManageIQ:master May 9, 2023
4 checks passed
@Fryguy
Copy link
Member

Fryguy commented May 9, 2023

Backported to petrosian in commit 17f0ac9.

commit 17f0ac936ba0904e2a4e53697d9f9a5c42558d93
Author: Jason Frey <fryguy9@gmail.com>
Date:   Tue May 9 12:10:24 2023 -0400

    Merge pull request #390 from bdunne/hotfix_build
    
    Add tools for building hotfix RPMs
    
    (cherry picked from commit 742284bfe35389b40ffeec4e53ffb4f6e53896f3)

Fryguy added a commit that referenced this pull request May 9, 2023
Add tools for building hotfix RPMs

(cherry picked from commit 742284b)
Fryguy added a commit that referenced this pull request May 9, 2023
Add tools for building hotfix RPMs

(cherry picked from commit 742284b)
(cherry picked from commit 17f0ac9)
@bdunne bdunne deleted the hotfix_build branch May 9, 2023 17:31
@Fryguy Fryguy added this to the Petrosian milestone Sep 14, 2023
@Fryguy Fryguy added this to Petrosian in Roadmap Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Roadmap
  
Petrosian
Development

Successfully merging this pull request may close these issues.

None yet

3 participants