RedHat is a system domain.

[lfu]

https://bugzilla.redhat.com/show_bug.cgi?id=1478574

@miq-bot add_label bug, fine/yes, gaprindashvili/yes

cc @mkanoor @gmcculloug @tinaafitz

[miq-bot]

Checked commit lfu@8ac28d9 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

db/migrate/20180313165320_set_red_hat_domain_to_system.rb

• ❗ - Line 6, Col 66 - Rails/SkipsModelValidations - Avoid using update_all because it skips validations.

[gmcculloug]

It is common practice to update the Automate domains stored on disk as part of an upgrade so this PR should not be needed. This domain's system attribute has already been updated in a separate change.

[gmcculloug]

In addition, anyone resetting the domains after this migration is applied would not see any effect, so if this type of logic is needed it would seem like seeding logic. But again I do not think we need this.

@lfu @Fryguy Could one of you please close this PR.