Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating Switches group migration #202

Closed

Conversation

EsdrasVP
Copy link
Member

This PR is able to:

  • Create a Switch group migration
  • Add PhysicalSwitches to Switches group

This change enable Switches to share its table with other implementations like PhysicalSwitches. This was necessary because making Switch as base model for PhysicalSwitch produced strange behaviors.

@miq-bot
Copy link
Member

miq-bot commented May 17, 2018

Checked commit EsdrasVP@56b8686 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@EsdrasVP
Copy link
Member Author

EsdrasVP commented May 18, 2018

This was resolved with a better solution in ManageIQ/manageiq#17431, so I'll close this PR.

@EsdrasVP EsdrasVP closed this May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants