Enable PhysicalStorage inside PhysicalChassis #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 21, 2018
Merged
EsdrasVP
force-pushed
the
add_storage_to_chassis
branch
from
7a54da7
to
1ae1fa9
Compare
|
LGTM, @agrare? |
|
LGTM too 👍 |
EsdrasVP
force-pushed
the
add_storage_to_chassis
branch
from
1ae1fa9
to
f7d2d8b
Compare
|
ping @Fryguy : please, merge |
|
@Fryguy could you merge it? |
Fryguy
requested changes
Jul 12, 2018
There was a problem hiding this comment.
@EsdrasVP You cannot modify a previous migration, because developers have already run this migration and it will leave their databases in an inconsistent state. Please create a new migration with a more recent timestamp (e.g. bundle exec rails generate migration AddPhysicalChassisIdToPhysicalStorages)
EsdrasVP
force-pushed
the
add_storage_to_chassis
branch
2 times, most recently
from
120509e
to
91e5c45
Compare
|
@Fryguy Fixed it, now there is a separate migration for it. |
|
Checked commit EsdrasVP@91e5c45 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Fryguy
approved these changes
Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is able to: