Add server profile template table for PhysicalServer #673
Conversation
@eilam20 it looks like you did a merge here instead of a rebase can you drop that commit and rebase your branch on master rather than merging master into your branch? See https://github.com/ManageIQ/guides/blob/master/developer_setup/git_workflow.md#git-configuration for our recommended git configuration |
| require_migration | ||
|
|
||
| # This is mostly necessary for data migrations, so feel free to delete this | ||
| # file if you do no need it. | ||
| describe CreatePhysicalServerProfileTemplates do | ||
| # let(:my_model_stub) { migration_stub(:MyModel) } | ||
|
|
||
| migration_context :up do | ||
| # Create data | ||
| # | ||
| # Example: | ||
| # | ||
| # my_model_stub.create!(attributes) | ||
|
|
||
| migrate | ||
|
|
||
| # Ensure data exists | ||
| # | ||
| # Example: | ||
| # | ||
| # expect(record).to have_attributes() | ||
| end | ||
|
|
||
| migration_context :down do | ||
| # Create data | ||
| # | ||
| # Example: | ||
| # | ||
| # my_model_stub.create!(attributes) | ||
|
|
||
| migrate | ||
|
|
||
| # Ensure data exists | ||
| # | ||
| # Example: | ||
| # | ||
| # expect(MyModel.count).to eq(0) | ||
| end | ||
| end |
There was a problem hiding this comment.
If you're simply adding a table you don't need to have a spec test (there is nothing to test aside from syntax which is already tested when we migrate up and down)
|
Now you have two merge commits @tzurvaza 😆 I can rebase if you want but you should get used to rebasing on master |
|
Looks like you don't have allow maintainer edits enabled so you'll have to fix this yourself |
eilam20
force-pushed
the
add_server_profile_template
branch
2 times, most recently
from
2f3112c
to
bb8888c
Compare
|
Minor but this is |
|
@agrare I dropped the commits and pushed it again with the rebase. |
eilam20
force-pushed
the
add_server_profile_template
branch
from
050f4b5
to
f850dad
Compare
ok, done |
|
Checked commit Autosde@f850dad with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
No description provided.