Replace Ruby 2.6 Array#difference #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 2.6 Array#difference() method was used without realizing it was added in 2.6 and not available in 2.5. Replacing with Array#-().
jerryk55
force-pushed
the
replace_Array_difference
branch
from
753e611
to
a3515d3
Compare
roliveri
approved these changes
Apr 16, 2020
|
Checked commit jerryk55@a3515d3 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
This was referenced Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 2.6 Array#difference() method was used without realizing
it was added in 2.6 and not available in 2.5.
Replacing with Array#-().
@roliveri please review.
Will be required in Ivanchuk as well.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1824259