New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to generate correct applications & patches info for windows scanning #75
Conversation
Checked commit hsong-rh@d07c496 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
@@ -124,7 +125,7 @@ def registry_applications_user_data(reg_node) | |||
end | |||
end | |||
|
|||
def registry_applications_app_paths(registry_doc, registry_path) | |||
def registry_applications_app_paths(registry_doc, registry_path, fs) | |||
return unless (reg_node = MIQRexml.findRegElement(registry_path, registry_doc.root)) | |||
postProcessApps(reg_node, fs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hsong-rh How did this ever work in the past? Do we know if there was a recent change that broke this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's broke by our recent refactor change #71
@@ -179,7 +180,7 @@ def registry_patches_packages(hotfix, element) | |||
return if element.attributes.nil? || element.attributes[:keyname].nil? | |||
if element.attributes[:keyname][0, 8] == 'Package_' | |||
# don't add this package if the ID is nil | |||
return if (hotfix_id = hotfix_id(e)).nil? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hsong-rh Same here, was this refactored or something that caused the breakage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same change as above: #71
Creating proper applications and patches list in scanning for window VMs.
https://bugzilla.redhat.com/show_bug.cgi?id=1597363