Clear previous messages, add miqSparkleOff to prevent infinite sparkle

ManageIQ · Dec 10, 2018 · 2035006 · 2035006
1 parent 74e4143
commit 2035006
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/app/assets/javascripts/components/generic_object/main-custom-button-form-component.js b/app/assets/javascripts/components/generic_object/main-custom-button-form-component.js
@@ -126,6 +126,7 @@ function mainCustomButtonFormController(API, miqService, $q, $http) {
 
   vm.saveClicked = function() {
     miqService.sparkleOn();
+    miqService.miqFlashClear(); // remove previous messages
     var saveMsg = sprintf(__('%s "%s" has been successfully saved.'), vm.entity, vm.customButtonModel.name);
     return API.put('/api/custom_buttons/' + vm.customButtonRecordId, vm.prepSaveObject(), {skipErrors: [400]})
       .then(function() {
@@ -136,6 +137,7 @@ function mainCustomButtonFormController(API, miqService, $q, $http) {
 
   vm.addClicked = function() {
     miqService.sparkleOn();
+    miqService.miqFlashClear(); // remove previous messages
     var saveMsg = sprintf(__('%s "%s" has been successfully added.'), vm.entity, vm.customButtonModel.name);
     return API.post('/api/custom_buttons/', vm.prepSaveObject(), {skipErrors: [400]})
       .then(function(response) {
@@ -205,6 +207,7 @@ function mainCustomButtonFormController(API, miqService, $q, $http) {
 
   // private functions
   function handleErrorMessages(error) {
+    miqSparkleOff();
     if (error.status === 400) {
       var errorMessages = error.data.error.message.split(',');
       errorMessages.forEach(function(message) {