Skip to content

Commit

Permalink
Prefer rr.report over rr.report_results in SavedReportPaging mixin
Browse files Browse the repository at this point in the history
https://bugzilla.redhat.com/show_bug.cgi?id=1590908

This not only makes it so we are consistent between the main controller
and the mixin, but this is also much faster to use this over
`MiqReportResult#report_results` when there is a large `binary_blob`
associated with the `MiqReportResult` record.
  • Loading branch information
NickLaMuro committed Jun 19, 2018
1 parent ff7ee24 commit b5260fd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/controllers/mixins/saved_report_paging.rb
Expand Up @@ -14,7 +14,7 @@ def saved_report_paging
@sb[:pages][:perpage] = settings(:perpage, :reports)

rr = MiqReportResult.find(@sb[:pages][:rr_id])
@html = report_build_html_table(rr.report_results,
@html = report_build_html_table(rr.report,
rr.html_rows(:page => @sb[:pages][:current],
:per_page => @sb[:pages][:perpage]).join)

Expand Down

0 comments on commit b5260fd

Please sign in to comment.