Confirmation popup is not needed on timelines screen.

"Abandon changes?" confirmation is not needed when leaving Timelines screen https://bugzilla.redhat.com/show_bug.cgi?id=1391220
ManageIQ · Jan 12, 2017 · bb666e3 · bb666e3
1 parent a470992
commit bb666e3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/app/assets/javascripts/miq_application.js b/app/assets/javascripts/miq_application.js
@@ -293,7 +293,9 @@ function miqDimDiv(divname, status) {
 // Check for changes and prompt
 function miqCheckForChanges() {
   if (ManageIQ.angular.scope) {
-    if (angular.isDefined(ManageIQ.angular.scope.angularForm) && ManageIQ.angular.scope.angularForm.$dirty) {
+    if (angular.isDefined(ManageIQ.angular.scope.angularForm) &&
+      ManageIQ.angular.scope.angularForm.$dirty &&
+      !miqDomElementExists('ignore_form_changes')) {
       var answer = confirm(__("Abandon changes?"));
       if (answer) {
         ManageIQ.angular.scope.angularForm.$setPristine(true);

diff --git a/app/views/layouts/_tl_options.html.haml b/app/views/layouts/_tl_options.html.haml
@@ -88,6 +88,7 @@
                               'ng-disabled' => 'reportModel.tl_categories.length === 0',
                               'class'       => 'timeline-apply'}
                 = _("Apply")
+            = hidden_field_tag(:ignore_form_changes)
 
 :javascript
   ManageIQ.angular.app.value('recordId', '#{@record.id}');